ref(options): migrate storage routing + ConfigurableComponent config to sentry-options#8115
Open
phacops wants to merge 2 commits into
Open
ref(options): migrate storage routing + ConfigurableComponent config to sentry-options#8115phacops wants to merge 2 commits into
phacops wants to merge 2 commits into
Conversation
…to sentry-options Migrate the storage-routing strategies and the ConfigurableComponent config system (allocation-policy / routing-strategy overrides) to read from sentry-options. ConfigurableComponent.get_config_value now consults a single configurable_component_overrides dict option (string values coerced to the config's declared type), layered ahead of the legacy Redis runtime config and the code default — so behavior is unchanged until the option is populated in sentry-options-automator. Editing happens via the automator, not snuba-admin. Keys migrated in this PR: configurable_component_overrides, storage_routing.enable_get_cluster_loadinfo, enable_long_term_retention_downsampling, storage_routing_config_override, default_storage_routing_config, storage_routing_sampled_too_low_threshold, storage_routing_time_budget_ms, storage_routing_max_items_before_downsampling, storage_routing_min_timerange_to_query_outcomes (default_tier is read here too; its schema entry was declared in the base infra PR.) Stacked on the EAP/RPC migration PR. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01U2Cu68uGZRcCVS14jcyd3E
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Module slice of the runtime-config → sentry-options migration (splitting #8096). Migrates the storage-routing strategies and the ConfigurableComponent config system (allocation-policy / routing-strategy overrides) to read from sentry-options.
ConfigurableComponent.get_config_valuenow consults a singleconfigurable_component_overridesdict option (string values coerced to the config's declared type), layered ahead of the legacy Redis runtime config and the code default — so behavior is unchanged until the option is populated in sentry-options-automator. Editing moves to the automator (not snuba-admin), consistent with the rest of this migration.Keys migrated here
configurable_component_overrides,storage_routing.enable_get_cluster_loadinfo,enable_long_term_retention_downsampling,storage_routing_config_override,default_storage_routing_config,storage_routing_sampled_too_low_threshold,storage_routing_time_budget_ms,storage_routing_max_items_before_downsampling,storage_routing_min_timerange_to_query_outcomes.(
default_tieris read here too; its schema entry was declared in the base infra PR.)Verification
ruff check+ruff format --checkclean;mypyclean on all changed files; 23test_configurable_componenttests pass locally. The routing-strategy tests need ClickHouse (not in the sandbox) and are covered by CI.🤖 Generated with Claude Code
Generated by Claude Code