ref(options): migrate query-execution / ClickHouse / cache config to sentry-options#8119
Closed
phacops wants to merge 2 commits into
Closed
ref(options): migrate query-execution / ClickHouse / cache config to sentry-options#8119phacops wants to merge 2 commits into
phacops wants to merge 2 commits into
Conversation
…options Migrate the lightweight-deletions off-peak scheduler, delete strategy, and the bulk/single delete query paths to read runtime config from sentry-options. Schema defaults match the prior get_*_config defaults, so behavior is unchanged until set in sentry-options-automator. Keys migrated in this PR: lw_deletions_offpeak_enabled/start/end, org_ids_delete_allowlist, max_parts_mutating_for_delete, permit_delete_by_attribute, MAX_ONGOING_MUTATIONS_FOR_DELETE, storage_deletes_enabled, enforce_max_rows_to_delete, lightweight_deletes_sync, lightweight_delete_mode (lw_deletes_killswitch / lw_deletes_split_by_partition are read here too; their schema entries were declared in the base infra PR.) query_settings and read_through_cache.short_circuit are also declared here because the delete tests toggle them as setup (cache bypass / query settings); their production call sites migrate in the query-exec PR later in the stack. Tests that toggled these via state.set_config(...) now use sentry_options.testing.override_options(...). Stacked on the replacer migration PR. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01U2Cu68uGZRcCVS14jcyd3E
…sentry-options Migrate the query-execution path (db_query, ClickHouse HTTP/native clients, result cache, physical query processors, SnQL parser limits, cluster selector, optimize util) to read runtime config from sentry-options. Schema defaults match the prior get_*_config defaults / sentinel-0 override semantics, so behavior is unchanged until set in sentry-options-automator. Keys migrated in this PR: enable_cache_partitioning, randomize_query_id, retry_duplicate_query_id, enable_bypass_cache_referrers, debug_buffer_size_bytes, cache_expiry_sec, ignore_clickhouse_settings_override, ignore_consistent_queries_sample_rate, slicing_mega_cluster_partitions, async_query_settings, query_settings_by_prefix, query_settings_by_referrer, optimize_parallel_threads, http_batch_join_timeout, simultaneous_queries_sleep_seconds, max_days, date_align_seconds, use.low.cardinality.processor, throw_on_uniq_select_and_having, function-validator.enabled, tags_hash_map_enabled, events_tags_hash_map_enabled, events_flags_hash_map_enabled (query_settings / read_through_cache.short_circuit are read here too; declared earlier in the stack by the deletes PR.) The per-storage clickhouse_load_balancing*/clickhouse_max_insert_block_size and quantized_rebalance map options are shared with the Rust consumers (already migrated in the Rust PR). Tests that toggled these via state.set_config(...) now use sentry_options.testing.override_options(...). Stacked on the deletes migration PR. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01U2Cu68uGZRcCVS14jcyd3E
phacops
force-pushed
the
claude/options-migration-deletes
branch
from
6b5439c to
f4a49fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded — the query-execution config migration was consolidated into #8118 (query-execution, cache & deletes) to keep the cross-cutting integration tests in a single PR. Closing in favor of #8118 + #8120. The Rust slice remains #8112.
🤖 Generated with Claude Code