ref(options): migrate rate-limit runtime config to sentry-options#8116
Open
phacops wants to merge 2 commits into
Open
ref(options): migrate rate-limit runtime config to sentry-options#8116phacops wants to merge 2 commits into
phacops wants to merge 2 commits into
Conversation
Migrate the rate-limiter and per-project quota-timing runtime config to sentry-options. Schema defaults match the prior get_*_config defaults, so behavior is unchanged until set in sentry-options-automator. Keys migrated in this PR: bypass_rate_limit, rate_history_sec, rate_limit_shard_factor, mem_rate_limit_per_sec, project_quota_time_percentage, counter_window_size_minutes, allows_skipping_single_project_replacements Tests that toggled these via state.set_config(...) now use sentry_options.testing.override_options(...). Stacked on the storage-routing / ConfigurableComponent migration PR. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01U2Cu68uGZRcCVS14jcyd3E
This was referenced Jun 26, 2026
…igration-rate-limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Module slice of the runtime-config → sentry-options migration (splitting #8096). Migrates the rate-limiter and per-project quota-timing runtime config to sentry-options. Schema defaults match the prior
get_*_configdefaults, so behavior is unchanged until set in sentry-options-automator.Keys migrated here
bypass_rate_limit,rate_history_sec,rate_limit_shard_factor,mem_rate_limit_per_sec,project_quota_time_percentage,counter_window_size_minutes,allows_skipping_single_project_replacements.Tests that toggled these via
state.set_config(...)now usesentry_options.testing.override_options(...).Verification
ruff check+ruff format --checkclean;mypyclean; 21/21tests/state/test_rate_limit.pypass locally.🤖 Generated with Claude Code
Generated by Claude Code