ref(options): migrate query-execution, cache & delete config to sentry-options#8118
Open
phacops wants to merge 2 commits into
Open
ref(options): migrate query-execution, cache & delete config to sentry-options#8118phacops wants to merge 2 commits into
phacops wants to merge 2 commits into
Conversation
This was referenced Jun 26, 2026
…y-options Consolidated slice covering the query-execution path, result cache, and the lightweight-delete path. These are grouped together because the broad API integration tests (test_api, test_search_issues_api, test_db_query, test_lw_deletions) toggle config keys read by source files across all three areas; splitting them further would leave an intermediate PR with a migrated read but a not-yet-converted test, so they must land together. Source areas: db_query, ClickHouse HTTP/native clients, result cache, physical query processors (clickhouse settings override, mapping optimizer, uniq), SnQL parser limits + function validator, low-cardinality processor, cluster selector, optimize util, the errors read-only storage selector, query-log COGS sampling, request consistency override, and the lw_deletions off-peak scheduler, delete strategy, and bulk/single delete query paths. Schema defaults match the prior get_*_config defaults (incl. sentinel-0 override semantics for optimize_parallel_threads / http_batch_join_timeout), so behavior is unchanged until set in sentry-options-automator. Tests that toggled these via state.set_config(...) now use sentry_options.testing.override_options(...). Stacked on the replacer migration PR. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01U2Cu68uGZRcCVS14jcyd3E
phacops
force-pushed
the
claude/options-migration-deletes
branch
from
6b5439c to
f4a49fa
Compare
phacops
changed the title
…migration-deletes # Conflicts: # tests/clickhouse/test_native.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidated module slice of the runtime-config → sentry-options migration (splitting #8096). Covers the query-execution path, the result cache, and the lightweight-delete path.
These three areas are grouped into one PR deliberately: the broad API/integration tests (
test_api,test_search_issues_api,test_db_query,test_lw_deletions) toggle config keys that are read by source files spread across all three. Splitting them further would leave an intermediate stacked PR with a key's read migrated but its test not yet converted (or vice-versa) — so they must land together to keep every PR green.Source areas:
db_query, the ClickHouse HTTP/native clients, the result cache, the physical query processors (clickhouse-settings override, mapping optimizer, uniq-in-select), SnQL parser limits + function validator, the low-cardinality processor, the cluster selector, optimize util, the errors read-only storage selector, query-log COGS sampling, request consistency override, and the lw_deletions off-peak scheduler / delete strategy / bulk + single delete query paths.Schema defaults match the prior
get_*_configdefaults (incl. the sentinel-0 override semantics foroptimize_parallel_threads/http_batch_join_timeout), so behavior is unchanged until set in sentry-options-automator.Tests that toggled these via
state.set_config(...)now usesentry_options.testing.override_options(...).Verification
ruff check+ruff format --checkclean;mypyclean on all 39 changed files; 57 redis-backed cache/processor/delete tests pass locally. The integration tests need ClickHouse (not in the sandbox) and are covered by CI.🤖 Generated with Claude Code