Add minBoundingRect function - #52
Draft
corot wants to merge 5 commits into
Draft
Conversation
corot
force-pushed
the
js/rot_calipers
branch
2 times, most recently
from
September 14, 2022 02:38
fe4cabd to
21c561c
Compare
corot
force-pushed
the
js/rot_calipers
branch
from
September 15, 2022 05:45
21c561c to
cecace2
Compare
Author
|
added link
…On Thu, Sep 15, 2022 at 10:45 AM ChristofDubs ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In costmap_2d/src/footprint.cpp
<#52 (comment)>
:
> @@ -66,6 +68,130 @@ void calculateMinAndMaxDistances(const std::vector<geometry_msgs::Point>& footpr
max_dist = std::max(max_dist, std::max(vertex_dist, edge_dist));
}
+BoundingRect minBoundingRect(const std::vector<geometry_msgs::Point>& points)
Q: did you come up with this implementation by yourself? Can you link
useful references you followed? Some general description of how this
function works would help me a lot to review this code.
—
Reply to this email directly, view it on GitHub
<#52 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACOYMW7AFMKP5WVNV6I4FTV6J5VHANCNFSM6AAAAAAQL7IORE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
renan028
marked this pull request as draft
February 18, 2025 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as part of https://www.wrike.com/open.htm?id=929048956, but we are not using it by now.
But anyway, the function is useful, so makes sense to merge
Please ignore the commit history; only the last one matters (the other are failed experiments)