Large Code Cleanup - #41
Open
QuzarDC wants to merge 38 commits into
Open
Conversation
added 30 commits
January 14, 2024 19:31
…Source. Every code path below it had those values overwritten before being read
…ased on IconSource. The intent seems to be to clear both if they had been previously populated from a repo
…r out existing repo-based images when adding custom ones, but that was both broken and doesn't make sense. It should be possible to replace individual images ad-hoc and there's no need to clear the variables directly before overwriting them.
…n source validation/ID.
…ce the popup to show up always on top. This shouldn't be neccessary at all.
…er in favor of testing the image previewbox. Ensure the text is set back to red when cleanup is performed.
… used for all images. Refactor the image loading to use a common function. Do away with global flags for testing if images have been loaded, and test the previewbox instead.
…se the ImageSourceLoad subfunction like the buttons, which should facilitate moving to a native tga saving.
…llow easier disabling of all options in the set rather than doing so individually.
added 8 commits
January 19, 2024 18:43
…ey haven't been done yet already. Use the readonly status of the key elements as the flag for if they are good or not.
…path UI element isn't being used as a scratchpad. Also remove the unnecessary initial settings of its contents.
…RepoDownload, disable RepoDownload button from start, invert logic in the systype radio buttons and make a shared common settings subfunction.
… to Hashes into a common function with the HashTest
…irst and possible second specified disc. Clean up the fail states for the build process to always clean up properly
…h Nintendont options. Correct alignments and overlaps in Advanced tab. Reduce c2w patcher label to a single element.
…n the checkmark is checked. Default elements to disabled, which would be disabled if switching to the Wii retail tab. Add borders around panels.
ZestyTS
added a commit
to ZestyTS/TeconmoonWiiVCInjector
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'd used your tool in setting up injections on my WiiU and thought I might help out with some cleanups. I tried to make the commits fairly atomic so that they could be actually reviewable. Most of it is refactoring and condensing the code (attempting to de-'SUPER CRAPPY' it). Along the way also fixed some bugs:
Some of the big non-bug changes: