Large Code Cleanup - #41

Open

QuzarDC wants to merge 38 commits into

piratesephiroth:mainfrom

QuzarDC:Quzar_Cleanups

Commits on Jan 15, 2024

Update project data for current VS
Donald Haase
committed
7e0d773
Clean up includes and references
Donald Haase
committed
469eee6
Simple refactor around nfs2iso2nfs
Donald Haase
committed
7ac7c7e
Refactor Hash checks
Donald Haase
committed
a5526d3
Prevent unhandled exception if TempRoot path doesn't exist
Donald Haase
committed
659218e
Refactor GC2SourceButton_Click
Donald Haase
committed
9e06409
Deduplicate code in DrcSourceButton, shift to local string
Donald Haase
committed
0ff4275
Deduplicate code in LogoSourceButton, shift to local string
Donald Haase
committed
50a94c7
Access BootSoundLoop checkbox directly when needed
Donald Haase
committed
e0654ab

Commits on Jan 16, 2024

Access DisablePassthrough Checkbox as needed on building args
Donald Haase
committed
33c066d
Collapse all 4 low drive space warnings into a single one
Donald Haase
committed
756d3f0
Clarify sequence of ifs into else-ifs and collapse file deletion checks
Donald Haase
committed
71d4373
Deduplicate code in BannerSourceButton
Donald Haase
committed
4d5a699
Remove pointless and duplicated setting of variables at top of BannerSource. Every code path below it had those values overwritten before being read
Donald Haase
committed
85b93dc
Reinstate duplicated FlagRepo check from BannerSource correcting it based on IconSource. The intent seems to be to clear both if they had been previously populated from a repo
Donald Haase
committed
33272e5
FlagRepo didn't do anything. The only time it was checked was to clear out existing repo-based images when adding custom ones, but that was both broken and doesn't make sense. It should be possible…
Donald Haase
committed
2aba57b

Commits on Jan 17, 2024

Reduce scope of GameType variable. It's only used between two tests in source validation/ID.
Donald Haase
committed
4dc2442
Deduplciate one line
Donald Haase
committed
5364d39
Remove custom flags for all message boxes. This seems to exist to force the popup to show up always on top. This shouldn't be neccessary at all.
Donald Haase
committed
216ce3f
Remove pngtemppath in favor of local vars. Remove flags for icon/banner in favor of testing the image previewbox. Ensure the text is set back to red when cleanup is performed.
Donald Haase
committed
e94f71e

Commits on Jan 18, 2024

Make the filename TempPath strings readonly and ensure they are being used for all images. Refactor the image loading to use a common function. Do away with global flags for testing if images have …
Donald Haase
committed
e70667c
Remove ref to FlagLogoSpecified
Donald Haase
committed
e442067
Create function for extracting string out of stream reader.
Donald Haase
committed
9a068c3
Refactor fail states in GameSourceButton_Click
Donald Haase
committed
3f100e7
Don't set the gamesourcedir stuff until we're sure it's a good file.
Donald Haase
committed
4cf20b5
Tighten WiiNAND title ID loop, and use a proper loop rather than gotos
Donald Haase
committed
6352464
Replace tga2png with native TGASharpLib. Simplify image loading
Donald Haase
committed
595a444

Commits on Jan 19, 2024

Commits on Jan 20, 2024

Reduce scope of the different build flags and TitleIDInt.
Donald Haase
committed
af4c2f7
Reduce scope of OGfilepath, and invert its use. Now the OpenGame.Filepath UI element isn't being used as a scratchpad. Also remove the unnecessary initial settings of its contents.
Donald Haase
committed
bb20df1

Commits on Jan 21, 2024

Commits on Jan 22, 2024

Commits on Jan 23, 2024

Adjust UI elements slightly. Specify custom dol now only shows up when the checkmark is checked. Default elements to disabled, which would be disabled if switching to the Wii retail tab. Add border…
Donald Haase
committed
b103877