This repository was archived by the owner on Jun 16, 2026. It is now read-only.
refactor: depend on single phoxal crate#10
Merged
Conversation
Replace the per-crate framework deps with one `phoxal` dependency and move
imports to phoxal::{bus,model,spatial,api,runtime}. Handle the asset GetResponse::Busy variant now exposed by current phoxal.
Cargo.lock regenerates once framework's `phoxal` is pushed; local builds use an
uncommitted .cargo/config.toml patch overlay.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
Signed-off-by: jbernavaprah <[email protected]>
Move from the `git branch=main` framework dep to the published `phoxal = "0.4.0"` and update for the post-#51 API: runtime::step->runtime, bus::zenoh_typed->zenoh, api leaf ::TOPIC->::path(), staged::Robot->model::v1::Robot, the #49 mission contract. Drops the local .cargo overlay; Cargo.lock now resolves phoxal from crates.io. Verified: cargo clippy --workspace --all-targets -- -D warnings + test green against the published crate. Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: jbernavaprah <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the coordinated single-
phoxal-crate migration (framework PR: phoxal/framework#51). Replaces the per-crate framework dependencies with onephoxaldep and moves imports tophoxal::{bus,model,spatial,api,runtime}. Also handles the assetGetResponse::Busyvariant exposed by currentphoxal.Merge phoxal/framework#51 first — this resolves
phoxalfrom framework'smainonce that lands.Cargo.lockwas intentionally not committed (it regenerates after framework is pushed/merged; local builds used an uncommitted.cargo/config.tomloverlay pinningphoxal→../framework/phoxal).Verified:
cargo check --workspace --all-targetsgreen against the localphoxal.🤖 Generated with Claude Code