Add count aggregation command tests#191
Conversation
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (4446+43 LOC, 20 files); LLM: Adds new test coverage for the count aggregation command, expanding the compatibility test suite. If a label is wrong, remove it manually and ping |
count aggregation command tests
Signed-off-by: Daniel Frankcom <[email protected]>
eerxuan
left a comment
There was a problem hiding this comment.
I feel "namespace", "maxTimeMS", "comment" and "read_concern" are cross cutting feature outside of the individual command layer. We may just need one test for each in every command folder. The full coverage should be in there own folder. We have query-and-write/read-concern/. I feel "comment" and "maxTimeMS" can belong to /cursor/. As mongosh has helper cursor.comment() and cursor.maxTimeMs(). "namespace" can be under /collections/.
I should have notice this earlier, we can reduce duplication start from new PRs and have a backlog to remove existing duplication later.
Remove the duplication for collation and view in this PR.
eerxuan
left a comment
There was a problem hiding this comment.
Can you add a rule in TEST_COVERAGE.md specify these command arguments are cross cutting features and where they belongs to.
Discussed offline.
|
Remove collation semantic/subfield tests (covered in collation/), namespace naming rules (common spec), and thorough view tests (merged into collection type tests). Add collection type acceptance tests including the view limit=0 quirk. Signed-off-by: Daniel Frankcom <[email protected]>
Done in #246 |
This change adds tests for the
countaggregation command.