Clean up merged commands based on cross-cutting feature discussion#246
Merged
Conversation
Remove fsync, getLastError, and provenance tests from writeConcern validation. These are deprecated/internal fields not part of the compatibility surface. Only documented spec options (w, j, wtimeout) are tested. Signed-off-by: Daniel Frankcom <[email protected]>
…on types Add guidance to FOLDER_STRUCTURE.md distinguishing cross-cutting parameters (collation, namespace) from command-specific parameters (readConcern, writeConcern), and documenting collection type as input. Update TEST_COVERAGE.md collection variants section. Signed-off-by: Daniel Frankcom <[email protected]>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, docs); effort from diff stats (139+1722 LOC, 13 files); LLM: Cleanup/polish of already-merged command scoping (removing out-of-spec writeConcern logic) plus docs update — no functional bug or blocker, primarily polish following a design discussion. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From comments and offline discussion in the context of #191, there are a few scope issues with commands that were already merged. This PR fixes those scope issues, primarily by removing
writeConcern-related logic that is not strictly part of the spec.I've also updated the
docs/testingdocumentation to better describe the distinction for cross-cutting concerns, following the discussion in #191.