Skip to content

Add distinct aggregation command tests#215

Open
danielfrankcom wants to merge 5 commits into
documentdb:mainfrom
danielfrankcom:pr/distinct
Open

Add distinct aggregation command tests#215
danielfrankcom wants to merge 5 commits into
documentdb:mainfrom
danielfrankcom:pr/distinct

Conversation

@danielfrankcom
Copy link
Copy Markdown
Collaborator

This change adds tests for the distinct aggregation command.

There is some overlap here with #191 as some of the framework changes are needed by both. I've included them here so they should merge cleanly.

@danielfrankcom danielfrankcom requested a review from a team as a code owner May 19, 2026 23:21
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 19, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.75 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (4333+37 LOC, 16 files); LLM: Adds new test coverage for the distinct aggregation command, which is a meaningful functional addition to the test suite.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

Signed-off-by: Daniel Frankcom <[email protected]>
Signed-off-by: Daniel Frankcom <[email protected]>
@danielfrankcom
Copy link
Copy Markdown
Collaborator Author

Added a few extra tests for views which fell out of working on the dedicated view collection tests.

Copy link
Copy Markdown
Collaborator

@eerxuan eerxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than view and collation trim as discussed before, LGTM.

Remove collation semantic/subfield tests (covered in collation/),
namespace naming rules and UUID resolution (common spec), and view
tests (merged into collection type tests). Add collection type
acceptance tests.
Signed-off-by: Daniel Frankcom <[email protected]>
@danielfrankcom danielfrankcom requested a review from eerxuan May 27, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants