Skip to content

many: renamed module to github.com/canonical/spread-plus to fix go install for spread-plus#81

Closed
ernestl wants to merge 1 commit into
canonical:mainfrom
ernestl:ernestl/change-module-name
Closed

many: renamed module to github.com/canonical/spread-plus to fix go install for spread-plus#81
ernestl wants to merge 1 commit into
canonical:mainfrom
ernestl:ernestl/change-module-name

Conversation

@ernestl

@ernestl ernestl commented Mar 24, 2026

Copy link
Copy Markdown
Member

This change should be followed up with: canonical/snapd#16813

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the Go module path to github.com/canonical/spread-plus so that go install works with the new repository/module location, and updates repository references accordingly.

Changes:

  • Update go.mod module path to github.com/canonical/spread-plus.
  • Update Go import paths and installation instructions to use the new module path.
  • Update spread configuration paths/environment variables and humbox documentation/redirect URLs to point at the new repo.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Renames the module path to github.com/canonical/spread-plus.
cmd/spread/main.go Updates internal import to the new module path.
cmd/humbox/main.go Updates GitHub URL references to the new repository.
README.md Updates go install instruction to the new module path.
spread.yaml Updates spread project checkout path to the new module path.
tests/repack/spread.yaml Updates GOPKG env var to the new module path for repack tests.
spread/client_test.go Updates test import path to the new module path.
spread/openstack_test.go Updates test import path to the new module path.
spread/project_test.go Updates test import path to the new module path.
spread/qemu_test.go Updates test import path to the new module path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/humbox/main.go
if req.URL.Path == "/" {
log.Printf("Request by %s to %s %s", req.RemoteAddr, req.Method, req.URL)
resp.Header().Set("Location", "http://github.com/snapcore/spread")
resp.Header().Set("Location", "http://github.com/canonical/spread-plus")

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect target uses plain HTTP. Since this is pointing to GitHub (which supports HTTPS), use an https:// URL to avoid an unnecessary downgrade/extra redirect and prevent clients from following an insecure Location header.

Suggested change
resp.Header().Set("Location", "http://github.com/canonical/spread-plus")
resp.Header().Set("Location", "https://github.com/canonical/spread-plus")

Copilot uses AI. Check for mistakes.
Comment thread cmd/spread/main.go
Comment on lines 14 to 16
"github.com/niemeyer/pretty"
"github.com/snapcore/spread/spread"
"github.com/canonical/spread-plus/spread"
)

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports in this block are not sorted (the module import should come before github.com/niemeyer/pretty). This will be rewritten by gofmt and may fail formatting checks; please run gofmt or reorder the imports.

Copilot uses AI. Check for mistakes.

@maykathm maykathm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestl

ernestl commented Mar 26, 2026

Copy link
Copy Markdown
Member Author

Closing this pull request, replaced by #82.
Not allowed to use branch for fork in this repo.

@ernestl ernestl closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants