Skip to content

packaging: update spread installation for autopkgtests to use github.com/canonical/spread#16812

Merged
ernestl merged 1 commit into
canonical:masterfrom
ernestl:ernestl/quick-fix-autopkgtests-spread-install
Mar 24, 2026
Merged

packaging: update spread installation for autopkgtests to use github.com/canonical/spread#16812
ernestl merged 1 commit into
canonical:masterfrom
ernestl:ernestl/quick-fix-autopkgtests-spread-install

Conversation

@ernestl

@ernestl ernestl commented Mar 24, 2026

Copy link
Copy Markdown
Member

Spread module name was changed in go.mod which breaks go based install of spread for autopkgtests: canonical/spread#281

122s 2026-03-24T05:45:21Z INFO Waiting for automatic snapd restart...
138s + export GOPATH=/tmp/go
138s + /snap/bin/go install github.com/snapcore/spread/cmd/spread@latest
138s go 1.26.1 from Canonical** installed
139s go: downloading github.com/snapcore/spread v0.0.0-20260323164801-a3a44a96b6d0
140s go: github.com/snapcore/spread/cmd/spread@latest: version constraints conflict:
140s 	github.com/snapcore/[email protected]: parsing go.mod:
140s 	module declares its path as: github.com/canonical/spread
140s 	        but was required as: github.com/snapcore/spread
140s autopkgtest [05:45:40]: test integrationtests: -----------------------]
140s autopkgtest [05:45:40]: test integrationtests:  - - - - - - - - - - results - - - - - - - - - -
140s integrationtests     FAIL non-zero exit status 1
141s autopkgtest [05:45:41]: @@@@@@@@@@@@@@@@@@@@ summary
141s integrationtests     FAIL non-zero exit status 1

This is a quick fix, to allow me to complete deb only release 2.74.1.
Adapt tests to use new module name.

Longer term we want to transition to using spread-plus. This work will follow soon:

@ernestl ernestl added this to the 2.74.1 milestone Mar 24, 2026
@ernestl ernestl requested review from bboozzoo, maykathm and zyga March 24, 2026 08:18
@ernestl ernestl added the Simple 😃 A small PR which can be reviewed quickly label Mar 24, 2026
@ernestl ernestl changed the title packaging: update spread installation for autopkgtests to use new mod… packaging: update spread installation for autopkgtests to use github.com/canonical/spread-plus Mar 24, 2026
@ernestl ernestl changed the title packaging: update spread installation for autopkgtests to use github.com/canonical/spread-plus packaging: update spread installation for autopkgtests to use github.com/canonical/spread Mar 24, 2026
@ernestl ernestl requested a review from sergiocazzolato March 24, 2026 08:26

@bboozzoo bboozzoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.55%. Comparing base (1ef8229) to head (3670399).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16812      +/-   ##
==========================================
- Coverage   77.63%   77.55%   -0.08%     
==========================================
  Files        1363     1364       +1     
  Lines      189126   188546     -580     
  Branches     2446     2446              
==========================================
- Hits       146827   146236     -591     
- Misses      33470    33478       +8     
- Partials     8829     8832       +3     
Flag Coverage Δ
unittests 77.55% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ernestl ernestl added the Skip spread Indicate that spread job should not run label Mar 24, 2026
@ernestl ernestl closed this Mar 24, 2026
@ernestl ernestl reopened this Mar 24, 2026
@github-actions

github-actions Bot commented Mar 24, 2026

Copy link
Copy Markdown

Tue Mar 24 09:00:35 UTC 2026

Spread tests skipped

@ernestl ernestl merged commit 15b8454 into canonical:master Mar 24, 2026
201 of 210 checks passed
ernestl added a commit to ernestl/snapd that referenced this pull request Mar 24, 2026
maykathm pushed a commit to maykathm/snapd that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants