many: transition to using spread-plus#16813
Merged
ernestl merged 2 commits intoMar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Transitions snapd’s autopkgtest/integration-test harness and contributor documentation to use spread-plus (module/snap) instead of the old github.com/snapcore/spread reference, aligning with the upstream module path change and the new tooling used by CI.
Changes:
- Update autopkgtest integration scripts to
go install github.com/canonical/spread-plus/cmd/spread@latest. - Update documentation links/references (HACKING/CONTRIBUTING/CODING) to point at
github.com/canonical/spread-plus. - Simplify core-initrd spread installation instructions to use the
spread-plussnap.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packaging/ubuntu-16.04/tests/integrationtests | Switches autopkgtest spread installation to spread-plus module path. |
| packaging/debian-sid/tests/integrationtests | Switches autopkgtest spread installation to spread-plus module path. |
| core-initrd/26.04/HACKING.md | Updates local testing docs to install spread via snap install spread-plus. |
| HACKING.md | Updates spread framework link to spread-plus in main contributor hacking guide. |
| CONTRIBUTING.md | Updates spread link to spread-plus in contributor guidelines. |
| CODING.md | Updates spread link to spread-plus in testing conventions. |
| the [spread](https://github.com/snapcore/spread) framework. For local testing | ||
| the [spread](https://github.com/canonical/spread-plus) framework. For local testing | ||
| you can install the `image-garden` snap that comes with pre-built releases of | ||
| upstream spread, qemu and all the support tools. Alternatively you may install |
There was a problem hiding this comment.
This paragraph now links to spread-plus, but it still says image-garden ships “upstream spread”, which is ambiguous given snapd’s tests require the plus variant (as noted just below). Consider rewording to explicitly say image-garden can provide spread-plus (or the plus variant) to avoid confusing readers.
Suggested change
| upstream spread, qemu and all the support tools. Alternatively you may install | |
| spread-plus (the plus variant of spread), qemu and all the support tools. Alternatively you may install |
Contributor
There was a problem hiding this comment.
needs a note to pick the plus variant in image-garden: snap set image-garden spread-variant=plus
Member
Author
There was a problem hiding this comment.
See my question to @zyga: https://chat.canonical.com/canonical/pl/b8bbc51fufyy9rzgr95a9deeoo
Member
Author
There was a problem hiding this comment.
Anyways, this note exists further down the para: additionally set ``snap set image-garden spread-variant=plus``
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16813 +/- ##
==========================================
- Coverage 77.61% 77.55% -0.06%
==========================================
Files 1356 1364 +8
Lines 189036 189116 +80
Branches 2446 2446
==========================================
- Hits 146713 146666 -47
- Misses 33448 33583 +135
+ Partials 8875 8867 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tue Mar 31 13:13:40 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
bboozzoo
reviewed
Mar 26, 2026
bboozzoo
reviewed
Mar 26, 2026
ernestl
force-pushed
the
ernestl/autoplktest-to-use-spread-plus
branch
from
0a03db4 to
814ed41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #16812, to transition to using spread-plus for autopkgtests.
This depends on: canonical/spread-plus#81 [Done]
Install works: