Halborn audit#457
Merged
Merged
Conversation
This reverts commit 9bc4876.
Add PendingActions::from_entries constructor and IntoIterator implementations for both owned and borrowed iteration. Add Restrictions helper methods: - blacklist/whitelist constructors for cleaner instantiation - normalized() for canonical form - members() for accessing member list Also add normalize_members helper to deduplicate member lists.
Replace duplicated bucket push logic with private helper method push_validated_entry. Used by both insert() and filter_without_leases() to reduce code duplication and centralize length tracking.
Replace linear search through assignments with RoleSet bit operations: - Add role_set_for helper returning RoleSet for an address - Optimize has_role to use RoleSet::contains - Optimize get_roles to use RoleSet filtering - Optimize is_allowed to compare RoleSet directly This reduces O(n) scans to O(1) bit operations.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced Jun 5, 2026
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be pushed onto spr/refactor/vault-ergonomics/4f330057 #417 when audit is complete
This change is