ci: remove duplicate workspace test run#518
Merged
peer2f00l merged 6 commits intoJul 22, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughSummary
Verification
Human review focus
WalkthroughThe PR centralizes fast tests, sandbox tests, and coverage under ChangesUnified test workflow
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CI as GitHub Actions
participant Justfile
participant Postgres
participant Sandbox as script/sandbox-up.sh
participant Nextest
CI->>Postgres: start shared service
CI->>Justfile: run test-fast or test-sandbox
Justfile->>Sandbox: start pooled neard and export RPC URLs
Justfile->>Nextest: run explicit filtered test set
Nextest->>Postgres: access test database
Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/test.ymlTraceback (most recent call last): Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/test.yml:
- Around line 505-536: Add a lightweight CI validation for the node-backed
package allowlist used by the “Run node-backed tests on a pooled neard sandbox”
step. Derive the expected package set from the node-backed predicate in
`.config/nextest.toml`, compare it with the packages passed via the step’s
`cargo nextest run -p` arguments, and fail loudly when they differ so the
workflow cannot silently omit tests.
- Around line 453-456: Rename the near-integration-tests job’s display name from
“NEAR / Workspace Integration Tests” to accurately describe the remaining
node-backed sandbox package tests, removing the outdated “Workspace” wording
while leaving the job key and execution configuration unchanged.
- Around line 457-471: Update the postgres service definition to reference an
immutable image digest instead of the mutable postgres:17.6 tag, while
preserving the existing PostgreSQL version and service configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 260f43e0-2c15-484d-ad32-207e0758e4b5
📒 Files selected for processing (1)
.github/workflows/test.yml
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3209d8e71e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@justfile`:
- Around line 76-78: Update the sandbox_packages extraction in the justfile
recipe to run python3 script/sandbox-packages.py as a regular pipeline whose
exit status is checked, rather than inside process substitution consumed by
mapfile. Preserve array-style package handling while making extraction failures
abort the recipe before any empty package list can disable -p narrowing.
In `@script/sandbox-up.sh`:
- Around line 73-78: Separate command substitution from export in the initial
NEAR_SANDBOX_RPC_URL assignment and inside the loop so cat failures remain
visible to set -e. Assign each addr_file result to the corresponding variable
first, then export it, preserving the existing variable names and node
iteration.
In `@service/funding-bridge/README.md`:
- Line 418: Update the documented funding-bridge test command to use the
sandbox-aware gate from the justfile’s sandbox_filter instead of plain
test-fast, ensuring the node-backed templar-funding-bridge tests are included
while preserving the existing package target.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 35e5250e-f41b-4cfe-8503-84f3c779edd8
📒 Files selected for processing (13)
.config/nextest.toml.github/workflows/test.ymlAGENTS.mdREADME.mdcontract/market/AGENTS.mddocs/src/testing.mdgateway/testing/src/bin/sandbox-host.rsjustfilescript/coverage.shscript/sandbox-packages.pyscript/sandbox-up.shscript/test.shservice/funding-bridge/README.md
💤 Files with no reviewable changes (1)
- script/test.sh
peer2f00l
deleted the
feature/eng-508-ci-near-integration-job-times-out-at-40m-1060s-workspace
branch
July 22, 2026 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: https://linear.app/templar-protocol/issue/ENG-508/ci-near-integration-job-times-out-at-40m-1060s-workspace-compile
Coverage proof
Verification
cargo fmt --all --check, Prettier, actionlint, andgit diff --checkThis change is