Fix atomic fee refresh summaries#454
Closed
carrion256 wants to merge 2 commits into
Closed
Conversation
…0-4b30-b15c-4a162208a604)
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…6cb-439d-ac3c-cdee6fb847c2)
Collaborator
Author
|
fixed on #457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RefreshFeesEffectSummaryproduced byprepare_atomic_callinto atomic withdraw/redeem summaries instead of discarding it.Findings
908f798c-e000-4b30-b15c-4a162208a604Verification
cargo test -p templar-soroban-runtime test_atomic_withdraw_refreshes_fees -- --nocapturecargo test -p templar-soroban-runtime --lib -- --nocapturesize-budget-checkhook passed:96709bytesThis change is