Skip to content

Fix atomic fee refresh summaries#454

Closed
carrion256 wants to merge 2 commits into
audit/fee-preview-and-proxy-view-truthfulnessfrom
audit/fee-atomic-final-a027-a029
Closed

Fix atomic fee refresh summaries#454
carrion256 wants to merge 2 commits into
audit/fee-preview-and-proxy-view-truthfulnessfrom
audit/fee-atomic-final-a027-a029

Conversation

@carrion256

@carrion256 carrion256 commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Merge the conditional RefreshFees EffectSummary produced by prepare_atomic_call into atomic withdraw/redeem summaries instead of discarding it.
  • Keeps the atomic return values unchanged while preserving emitted/effect-summary accounting for fee mint effects once atomic paths are reachable.

Findings

  • #FIND-030 / Nexus 908f798c-e000-4b30-b15c-4a162208a604
  • A-027 / #FIND-028 is covered by the base PR's proxy-view truthfulness work; no extra code in this PR.

Verification

  • cargo test -p templar-soroban-runtime test_atomic_withdraw_refreshes_fees -- --nocapture
  • cargo test -p templar-soroban-runtime --lib -- --nocapture
  • post-commit Soroban size-budget-check hook passed: 96709 bytes

This change is Reviewable

@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6aaae876-48fd-414e-8f9c-ba91aa98cdfd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch audit/fee-atomic-final-a027-a029

Comment @coderabbitai help to get the list of available commands and usage tips.

@carrion256

Copy link
Copy Markdown
Collaborator Author

fixed on #457

@carrion256 carrion256 closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant