fix(customizer): CVE remediation#452
Conversation
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR repoints Automodel Docker builds to PyTorch 26.05, rebuilds CUDA wheel stages, removes ChangesAutomodel build and embedding updates
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
services/automodel/src/nmp/automodel/tasks/training/backends/checkpoints.py (1)
358-372: 🩺 Stability & Availability | 🟠 MajorFix the exporter import path in
services/automodel/src/nmp/automodel/tasks/training/backends/checkpoints.py:358
nemo_automodel.components.models.llama_bidirectional.export_onnxis not present in the shippednemo_automodelpackage; this import will fail when embedding export runs. Point it at the actual biencoder exporter module.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@services/automodel/src/nmp/automodel/tasks/training/backends/checkpoints.py` around lines 358 - 372, The embedding export import in the checkpoint export flow points to a non-shipped llama_bidirectional module, so the import will fail at runtime. Update the import used in the embedding export path inside the checkpoint logic to reference the actual biencoder exporter module, and make sure the call to export_to_onnx still uses the same arguments in the surrounding try block.services/automodel/src/nmp/automodel/tasks/training/backends/config.py (1)
80-114: 🩺 Stability & Availability | 🔴 CriticalPoint this config at the biencoder class and move
temperatureintomodel.
cfg["temperature"]is ignored here;TrainBiencoderRecipeonly instantiatesself.cfg.model, andLlamaBidirectionalModelreadstemperaturefrom the model config.nemo_automodel._transformers.auto_model.NeMoAutoModelBiEncoderis not present; usenemo_automodel.components.models.biencoder.biencoder_model.NeMoAutoModelBiencoder.make_retrieval_datasettakestrain_n_passages, and the collator isRetrievalBiencoderCollator.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@services/automodel/src/nmp/automodel/tasks/training/backends/config.py` around lines 80 - 114, The embedding-model config is pointing at the wrong backend and placing `temperature` in the wrong scope: `TrainBiencoderRecipe` only uses `cfg["model"]`, so move `temperature` under the `model` config instead of the top level. In the `_is_embedding_model` branch of the config builder, replace the current `NeMoAutoModelBiEncoder.from_pretrained` target with `nemo_automodel.components.models.biencoder.biencoder_model.NeMoAutoModelBiencoder`, and keep the rest of the biencoder-specific settings aligned with `LlamaBidirectionalModel` expectations.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@services/automodel/src/nmp/automodel/tasks/training/backends/finetune.py`:
- Line 20: The import in the finetune training backend points to the wrong
recipe module and class name. Update the reference used by the training backend
to the biencoder API exposed by nemo_automodel 0.2.0, replacing
TrainBiEncoderRecipe from nemo_automodel.recipes.retrieval.train_bi_encoder with
TrainBiencoderRecipe from nemo_automodel.recipes.biencoder.train_biencoder, and
make sure any corresponding references in the same backend match the new symbol
names.
---
Outside diff comments:
In `@services/automodel/src/nmp/automodel/tasks/training/backends/checkpoints.py`:
- Around line 358-372: The embedding export import in the checkpoint export flow
points to a non-shipped llama_bidirectional module, so the import will fail at
runtime. Update the import used in the embedding export path inside the
checkpoint logic to reference the actual biencoder exporter module, and make
sure the call to export_to_onnx still uses the same arguments in the surrounding
try block.
In `@services/automodel/src/nmp/automodel/tasks/training/backends/config.py`:
- Around line 80-114: The embedding-model config is pointing at the wrong
backend and placing `temperature` in the wrong scope: `TrainBiencoderRecipe`
only uses `cfg["model"]`, so move `temperature` under the `model` config instead
of the top level. In the `_is_embedding_model` branch of the config builder,
replace the current `NeMoAutoModelBiEncoder.from_pretrained` target with
`nemo_automodel.components.models.biencoder.biencoder_model.NeMoAutoModelBiencoder`,
and keep the rest of the biencoder-specific settings aligned with
`LlamaBidirectionalModel` expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6cf66553-20ac-4dd1-b0e7-1c31c72e255c
📒 Files selected for processing (11)
docker/Dockerfile.nmp-automodel-basedocker/automodel/README.mddocker/automodel/cherry-picks/3d98f6e3.diffdocker/automodel/cherry-picks/e6d2930a.diffdocker/base/Dockerfile.mamba-wheelservices/automodel/src/nmp/automodel/tasks/training/backends/checkpoints.pyservices/automodel/src/nmp/automodel/tasks/training/backends/config.pyservices/automodel/src/nmp/automodel/tasks/training/backends/finetune.pyservices/automodel/tests/contract/README.mdservices/automodel/tests/contract/output_configs/embed_1b_full_sft.yamlservices/automodel/tests/contract/output_configs/embed_1b_lora.yaml
💤 Files with no reviewable changes (1)
- docker/automodel/cherry-picks/e6d2930a.diff
|
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Summary by CodeRabbit
temperaturesetting.torchcodec, removing older video dependencies.