fix(customizer): unsloth image CVE resolution - #464
Conversation
Signed-off-by: Sam Oluwalana <[email protected]>
…doesn't include failing versions even if shadowed Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
📝 WalkthroughWalkthroughUpdated Docker base tags and CUDA 13.2 image inputs, added runtime cleanup of stale system packages, and pinned ChangesContainer dependency alignment
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/Dockerfile.nmp-automodel-base`:
- Around line 136-137: The cleanup in the Dockerfile still targets the grpcio
package metadata instead of the actual runtime package. Update the dist-packages
removal list to delete the top-level grpc directory rather than grpcio, and keep
the existing grpcio-*.dist-info cleanup so the installed code is fully removed.
In `@docker/Dockerfile.nmp-unsloth-training`:
- Line 176: The Docker dependency pin for aiohttp is still lower than the
project requirement, so update the aiohttp constraint in
docker/Dockerfile.nmp-unsloth-training to match the floor used in
pyproject.toml. Locate the aiohttp package entry in the Dockerfile and raise the
minimum version from 3.13.3 to 3.13.4 so the container build matches the
declared dependency policy.
In `@pyproject.toml`:
- Line 88: The mlflow-skinny dependency floor in pyproject.toml is still lower
than the training image constraint; update the dependency entry for
mlflow-skinny so its minimum version matches the Dockerfiles’ 3.11.1 floor while
keeping the existing upper bound and intent of the optional fine-tuning
dependency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0cdb9ff9-2bfe-48a0-9ebf-2c47c1825f6a
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
docker/Dockerfile.nmp-automodel-basedocker/Dockerfile.nmp-unsloth-trainingpyproject.toml
|
Signed-off-by: Sam Oluwalana <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker-bake.hcl`:
- Line 78: The automodel docs and eval comments still describe the default base
reference as local or $BAKE_TAG, but the pinned prebuilt base tag is now the
source of truth. Update the documentation and any related comments in the
automodel README and the image-env script so they describe BASE_TAG_AUTOMODEL as
only relevant when USE_PREBUILT_BASES is enabled, and make sure the wording
matches the pinned tag used by the bake configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 85865e84-5eae-4b5f-8448-21bca08c84e6
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
docker-bake.hcldocker/Dockerfile.nmp-automodel-basedocker/Dockerfile.nmp-unsloth-trainingpyproject.toml
🚧 Files skipped from review as they are similar to previous changes (3)
- pyproject.toml
- docker/Dockerfile.nmp-automodel-base
- docker/Dockerfile.nmp-unsloth-training
Summary by CodeRabbit
New Features
mlflow-skinnyandgrpcio.Bug Fixes
0.49.2.Documentation