fix(customizer): address CVEs in unsloth and automodel#474
Conversation
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughDependency constraints and image pins were updated for ChangesContainer dependency and license metadata updates
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/Dockerfile.nmp-automodel-base (1)
108-113: 📐 Maintainability & Code Quality | 🟡 MinorDrop the duplicate
wandbspec.uvtreats repeated package requirements as conflicting, so keep only one ofwandb>=0.27.2,<1orwandb==0.27.2indocker/Dockerfile.nmp-automodel-base:108-113.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/Dockerfile.nmp-automodel-base` around lines 108 - 113, The dependency list in the Dockerfile has a duplicate wandb requirement that uv treats as conflicting. In the package install block, keep only one wandb specifier by removing either the broad version range or the pinned wandb==0.27.2 entry, and leave the other dependencies unchanged.
🧹 Nitpick comments (1)
docker/Dockerfile.nmp-automodel-base (1)
126-129: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueComment at Lines 123-125 now mismatches its target.
The
rm -rf (not pip uninstall)note now sits above the new apt openssl RUN instead of the dist-packagesrm -rf(Line 130). Move the apt RUN below the cleanup block, or relocate the comment, to avoid confusion.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/Dockerfile.nmp-automodel-base` around lines 126 - 129, The comment placement is now misleading because the `rm -rf (not pip uninstall)` note no longer matches the cleanup it refers to. In `Dockerfile.nmp-automodel-base`, move the new `apt-get update` / `apt-get install` `RUN` block so it comes after the dist-packages cleanup block, or relocate the comment to sit directly above the cleanup it describes. Keep the existing `RUN` instructions grouped logically so the comment and the referenced `rm -rf` remain aligned.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docker/Dockerfile.nmp-automodel-base`:
- Around line 108-113: The dependency list in the Dockerfile has a duplicate
wandb requirement that uv treats as conflicting. In the package install block,
keep only one wandb specifier by removing either the broad version range or the
pinned wandb==0.27.2 entry, and leave the other dependencies unchanged.
---
Nitpick comments:
In `@docker/Dockerfile.nmp-automodel-base`:
- Around line 126-129: The comment placement is now misleading because the `rm
-rf (not pip uninstall)` note no longer matches the cleanup it refers to. In
`Dockerfile.nmp-automodel-base`, move the new `apt-get update` / `apt-get
install` `RUN` block so it comes after the dist-packages cleanup block, or
relocate the comment to sit directly above the cleanup it describes. Keep the
existing `RUN` instructions grouped logically so the comment and the referenced
`rm -rf` remain aligned.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 67132824-fb1b-4f17-86e8-6d3942165383
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
docker/Dockerfile.nmp-automodel-basedocker/Dockerfile.nmp-automodel-trainingdocker/Dockerfile.nmp-unsloth-trainingpyproject.toml
💤 Files with no reviewable changes (1)
- docker/Dockerfile.nmp-automodel-training
|
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/Dockerfile.nmp-automodel-base`:
- Around line 136-142: The Dockerfile currently installs the VLM extra but then
removes av/cv2 packages, leaving a broken runtime for the supported VLM paths.
Update the image build in Dockerfile.nmp-automodel-base so the packages required
by the VLM flow remain available: either stop enabling the affected
extra/packages during install or replace the post-sync deletion with patched
PyAV/OpenCV wheels. Verify the build steps that install --extra vlm and the VLM
support paths stay consistent with the final site-packages contents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c2ce1b23-f18b-48a8-9d3f-86471d2be5bc
📒 Files selected for processing (1)
docker/Dockerfile.nmp-automodel-base
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
…pencv build with ffmpeg 8.1.2+ Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
fix(customizer): fix dockerfile organization for customizer, add AV opencv build with ffmpeg 8.1.2+
Summary by CodeRabbit