Skip to content

fix: replace hardcoded edX with platformName in basicBannerTitle message #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 2 commits into from
Nov 28, 2025
Merged

fix: replace hardcoded edX with platformName in basicBannerTitle message #2711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1857e6c
fix: replace hardcoded edX with platformName in basicBannerTitle message
Anas12091101 Nov 28, 2025
88e2ec1
fix: test
Anas12091101 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/schedule-and-details/basic-section/BasicSection.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('<BasicSection />', () => {
it('shows the page banner if the marketingEnabled is true', () => {
const { getByText, queryAllByText } = render(<RootWrapper {...props} />);
expect(
getByText(messages.basicBannerTitle.defaultMessage),
getByText(`Promoting your course with ${props.platformName}`),
).toBeInTheDocument();
expect(
getByText(messages.basicBannerText.defaultMessage),
Expand All @@ -66,7 +66,7 @@ describe('<BasicSection />', () => {
).toBeInTheDocument();
expect(getByText(props.lmsLinkForAboutPage)).toBeInTheDocument();
expect(inviteButton).toBeInTheDocument();
expect(queryAllByText(messages.basicBannerTitle.defaultMessage).length).toBe(0);
expect(queryAllByText(`Promoting your course with ${props.platformName}`).length).toBe(0);
});

it('checks link link to invite', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/schedule-and-details/basic-section/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const BasicSection = ({
onDismiss={() => setShowPageBanner(false)}
className="align-items-start"
>
<h4 className="text-black">{intl.formatMessage(messages.basicBannerTitle)}</h4>
<h4 className="text-black">{intl.formatMessage(messages.basicBannerTitle, { platformName })}</h4>
<span className="text text-gray-700 text-left">
{intl.formatMessage(messages.basicBannerText)}
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/schedule-and-details/basic-section/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const messages = defineMessages({
},
basicBannerTitle: {
id: 'course-authoring.schedule.basic.banner.title',
defaultMessage: 'Promoting your course with edX',
defaultMessage: 'Promoting your course with {platformName}',
},
basicBannerText: {
id: 'course-authoring.schedule.basic.banner.text',
Expand Down