fix: replace hardcoded edX with platformName in basicBannerTitle message#2711
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2711 +/- ##
========================================
Coverage 94.86% 94.86%
========================================
Files 1233 1233
Lines 27940 27940
Branches 6337 6150 -187
========================================
Hits 26505 26505
- Misses 1364 1377 +13
+ Partials 71 58 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
How do I get the banner to appear? I don't see it on a normal course's "Schedule & Details" page. |
|
I'm sorry for the oversight. I should have included this in the testing instructions. Please add the following settings to your edx-platform instance to display the banner: |
Description
This PR replaces the hardcoded "edX" with
platformNamein thebasicBannerTitlemessage.Useful information to include:
Supporting information
https://github.com/mitodl/hq/issues/9362
Testing instructions
basicbannerTItlereflects the platform name instead of edX on the Scheduling & Details pageOther information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'