chore: fix incorrect or missing 'await' usages#2592
chore: fix incorrect or missing 'await' usages#2592bradenmacdonald merged 6 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
402d0b8 to
83debd3
Compare
83debd3 to
7d97e99
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2592 +/- ##
==========================================
+ Coverage 95.14% 95.18% +0.03%
==========================================
Files 1274 1318 +44
Lines 29835 30012 +177
Branches 6759 6759
==========================================
+ Hits 28386 28566 +180
- Misses 1377 1387 +10
+ Partials 72 59 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d97e99 to
6054354
Compare
6054354 to
d894ab8
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
Great work! Looks good! 👍
- I tested this: I have performed a general test of the platform
- I read through the code and considered the security, stability and performance implications of the changes.
8a9d4c2 to
9209509
Compare
9209509 to
4c4d9ad
Compare
Found using oxlint. This fixes more incorrect/missing
awaitusages.Rule documentation:
Part of #2559
Private ref MNG-4763