Skip to content

chore: fix incorrect or missing 'await' usages#2592

Merged
bradenmacdonald merged 6 commits intoopenedx:masterfrom
open-craft:braden/oxlint-await-2
Jan 29, 2026
Merged

chore: fix incorrect or missing 'await' usages#2592
bradenmacdonald merged 6 commits intoopenedx:masterfrom
open-craft:braden/oxlint-await-2

Conversation

@bradenmacdonald
Copy link
Copy Markdown
Contributor

Found using oxlint. This fixes more incorrect/missing await usages.

Rule documentation:

  ⚠ typescript-eslint(await-thenable): Unexpected `await` of a non-Promise (non-"Thenable") value.
    ╭─[src/pages-and-resources/app-settings-modal/AppSettingsModal.jsx:81:5]
 80 │     }
 81 │     await setSaveError(!success);
    ·     ────────────────────────────
 82 │     !success && alertRef?.current.scrollIntoView(); // eslint-disable-line @typescript-eslint/no-unused-expressions
    ╰────
  ⚠ typescript-eslint(no-floating-promises): Promises must be awaited.
    ╭─[src/course-checklist/CourseChecklist.test.jsx:65:9]
 64 │         renderComponent();
 65 │         mockStore(200);
    ·         ───────────────
 66 │ 
    ╰────
  help: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator.

Part of #2559

Private ref MNG-4763

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 31, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 31, 2025
@bradenmacdonald bradenmacdonald force-pushed the braden/oxlint-await-2 branch 2 times, most recently from 402d0b8 to 83debd3 Compare November 4, 2025 00:22
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (5d97a98) to head (ee36340).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
+ Coverage   95.14%   95.18%   +0.03%     
==========================================
  Files        1274     1318      +44     
  Lines       29835    30012     +177     
  Branches     6759     6759              
==========================================
+ Hits        28386    28566     +180     
- Misses       1377     1387      +10     
+ Partials       72       59      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good! 👍

  • I tested this: I have performed a general test of the platform
  • I read through the code and considered the security, stability and performance implications of the changes.

@bradenmacdonald bradenmacdonald force-pushed the braden/oxlint-await-2 branch 2 times, most recently from 8a9d4c2 to 9209509 Compare January 28, 2026 22:20
@bradenmacdonald bradenmacdonald merged commit 9d9d7a7 into openedx:master Jan 29, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in Contributions Jan 29, 2026
@bradenmacdonald bradenmacdonald deleted the braden/oxlint-await-2 branch January 29, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants