chore: fix incorrect or missing 'await' usages

Author: bradenmacdonald

plugins/course-apps/live/Settings.jsx

@@ -72,7 +72,7 @@ const LiveSettings = ({
   };
 
   const handleSettingsSave = async (values) => {
-    // oxlint-disable-next-line @typescript-eslint/await-thenable - this IS a promise; it just has wrong type info.
+    // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
     await dispatch(saveLiveConfiguration(courseId, values, navigate));
   };
 

plugins/course-apps/ora_settings/Settings.jsx

@@ -50,6 +50,7 @@ const ORASettings = ({ onClose }) => {
     success = success && await handleSettingsSave(formValues);
     setSaveError(!success);
     if ((initialFormValues.enableFlexiblePeerGrade !== formValues.enableFlexiblePeerGrade) && success) {
+      // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
       success = await dispatch(updateModel({
         modelType: 'courseApps',
         model: {

plugins/course-apps/xpert_unit_summary/settings-modal/SettingsModal.jsx

@@ -239,10 +239,10 @@ const SettingsModal = ({
     const values = { ...rest, enabled: enabled ? checked === 'true' : undefined };
 
     if (enabled) {
-      // oxlint-disable-next-line @typescript-eslint/await-thenable - this IS a promise; it just has wrong type info.
+      // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
       success = await dispatch(updateXpertSettings(courseId, values));
     } else {
-      // oxlint-disable-next-line @typescript-eslint/await-thenable - this IS a promise; it just has wrong type info.
+      // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
       success = await dispatch(removeXpertSettings(courseId));
     }
 

src/certificates/certificates-list/hooks/useCertificatesList.jsx

@@ -25,7 +25,7 @@ const useCertificatesList = (courseId) => {
   }));
 
   const handleSubmit = async (values) => {
-    // oxlint-disable-next-line @typescript-eslint/await-thenable - this IS a promise; it just has wrong type info.
+    // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
     await dispatch(updateCourseCertificate(courseId, values));
     setEditModes({});
     dispatch(setMode(MODE_STATES.view));

src/content-tags-drawer/data/apiHooks.ts

@@ -172,6 +172,7 @@ export const useContentTaxonomyTagsUpdater = (contentId: string) => {
         // feature to support the legacy Django template courseware page.
 
         // Sends content tags.
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         getContentTaxonomyTagsData(contentId).then((data) => {
           const contentData = { contentId, ...data };
 
@@ -187,6 +188,7 @@ export const useContentTaxonomyTagsUpdater = (contentId: string) => {
         });
 
         // Sends tags count.
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         getContentTaxonomyTagsCount(contentId).then((count) => {
           const contentData = { contentId, count };
 

src/course-libraries/LegacyLibContentBlockAlert.tsx

@@ -31,11 +31,13 @@ const LegacyLibContentBlockAlert = ({ courseId }: Props) => {
     if (taskStatus.data?.state === UserTaskStatus.Succeeded) {
       showToast(intl.formatMessage(messages.legacyLibReadyToMigrateTaskCompleted));
       setTaskId(undefined);
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       refetch();
     } else if (taskStatus.data?.state === UserTaskStatus.Failed
       || taskStatus.data?.state === UserTaskStatus.Cancelled) {
       showToast(intl.formatMessage(messages.legacyLibReadyToMigrateTaskFailed));
       setTaskId(undefined);
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       refetch();
     } else if (taskId) {
       showToast(intl.formatMessage(messages.legacyLibReadyToMigrateTaskInProgress));

src/course-outline/CourseOutline.test.tsx

@@ -471,11 +471,11 @@ describe('<CourseOutline />', () => {
     const dummyBtn = await screen.findByRole('button', { name: 'Dummy button' });
     fireEvent.click(dummyBtn);
 
-    waitFor(() => expect(axiosMock.history.post.length).toBe(3));
+    await waitFor(() => expect(axiosMock.history.post.length).toBe(3));
 
     const [section] = courseOutlineIndexMock.courseStructure.childInfo.children;
     const [subsection] = section.childInfo.children;
-    waitFor(() => {
+    await waitFor(() => {
       expect(axiosMock.history.post[2].data).toBe(JSON.stringify({
         type: COMPONENT_TYPES.libraryV2,
         category: 'vertical',
@@ -509,10 +509,10 @@ describe('<CourseOutline />', () => {
     const dummyBtn = await screen.findByRole('button', { name: 'Dummy button' });
     fireEvent.click(dummyBtn);
 
-    waitFor(() => expect(axiosMock.history.post.length).toBe(3));
+    await waitFor(() => expect(axiosMock.history.post.length).toBe(3));
 
     const [section] = courseOutlineIndexMock.courseStructure.childInfo.children;
-    waitFor(() => {
+    await waitFor(() => {
       expect(axiosMock.history.post[2].data).toBe(JSON.stringify({
         type: COMPONENT_TYPES.libraryV2,
         category: 'sequential',
@@ -545,10 +545,10 @@ describe('<CourseOutline />', () => {
     const dummyBtn = await screen.findByRole('button', { name: 'Dummy button' });
     fireEvent.click(dummyBtn);
 
-    waitFor(() => expect(axiosMock.history.post.length).toBe(3));
+    await waitFor(() => expect(axiosMock.history.post.length).toBe(3));
 
     const courseUsageKey = courseOutlineIndexMock.courseStructure.id;
-    waitFor(() => {
+    await waitFor(() => {
       expect(axiosMock.history.post[2].data).toBe(JSON.stringify({
         type: COMPONENT_TYPES.libraryV2,
         category: 'chapter',

src/course-outline/OutlineAddChildButtons.tsx

@@ -321,6 +321,7 @@ const LegacyOutlineAddChildButtons = ({
   }
 
   const handleOnComponentSelected = (selected: SelectedComponent) => {
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     onUseLibraryContent(selected);
     closeAddLibrarySectionModal();
   };

src/course-outline/card-header/CardHeader.test.tsx

@@ -229,7 +229,7 @@ describe('<CardHeader />', () => {
     });
 
     expect(await screen.findByTestId('subsection-edit-field')).toBeInTheDocument();
-    waitFor(() => {
+    await waitFor(() => {
       expect(screen.queryByTestId('subsection-card-header__expanded-btn')).not.toBeInTheDocument();
       expect(screen.queryByTestId('edit-button')).not.toBeInTheDocument();
     });

src/course-outline/hooks.jsx

@@ -113,6 +113,7 @@ const useCourseOutline = ({ courseId }) => {
 
   const headerNavigationsActions = {
     handleNewSection: () => {
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       handleAddSection.mutateAsync({
         type: ContainerType.Chapter,
         parentLocator: courseStructure?.id,