chore: fix incorrect or missing 'await' usages

plugins/course-apps/live/Settings.jsx

@@ -72,6 +72,7 @@ const LiveSettings = ({
   };
 
   const handleSettingsSave = async (values) => {
+    // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
     await dispatch(saveLiveConfiguration(courseId, values, navigate));
   };
 

plugins/course-apps/ora_settings/Settings.jsx

@@ -48,8 +48,9 @@ const ORASettings = ({ onClose }) => {
     event.preventDefault();
 
     success = success && await handleSettingsSave(formValues);
-    await setSaveError(!success);
+    setSaveError(!success);
     if ((initialFormValues.enableFlexiblePeerGrade !== formValues.enableFlexiblePeerGrade) && success) {
+      // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
       success = await dispatch(updateModel({
         modelType: 'courseApps',
         model: {

plugins/course-apps/ora_settings/Settings.test.jsx

@@ -128,7 +128,7 @@ describe('ORASettings', () => {
     await mockStore({ apiStatus: 200, enabled: true });
     renderComponent();
 
-    const checkbox = await screen.getByRole('checkbox', { name: /Flex Peer Grading/ });
+    const checkbox = screen.getByRole('checkbox', { name: /Flex Peer Grading/ });
     expect(checkbox).toBeChecked();
 
     await waitFor(() => {

plugins/course-apps/xpert_unit_summary/settings-modal/SettingsModal.jsx

@@ -239,8 +239,10 @@ const SettingsModal = ({
     const values = { ...rest, enabled: enabled ? checked === 'true' : undefined };
 
     if (enabled) {
+      // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
       success = await dispatch(updateXpertSettings(courseId, values));
     } else {
+      // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
       success = await dispatch(removeXpertSettings(courseId));
     }
 

src/certificates/certificates-list/hooks/useCertificatesList.jsx

@@ -25,6 +25,7 @@ const useCertificatesList = (courseId) => {
   }));
 
   const handleSubmit = async (values) => {
+    // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
     await dispatch(updateCourseCertificate(courseId, values));
     setEditModes({});
     dispatch(setMode(MODE_STATES.view));

src/content-tags-drawer/data/apiHooks.ts

@@ -172,6 +172,7 @@ export const useContentTaxonomyTagsUpdater = (contentId: string) => {
         // feature to support the legacy Django template courseware page.
 
         // Sends content tags.
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         getContentTaxonomyTagsData(contentId).then((data) => {
           const contentData = { contentId, ...data };
 
@@ -187,6 +188,7 @@ export const useContentTaxonomyTagsUpdater = (contentId: string) => {
         });
 
         // Sends tags count.
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         getContentTaxonomyTagsCount(contentId).then((count) => {
           const contentData = { contentId, count };
 

src/course-checklist/CourseChecklist.test.jsx

@@ -46,9 +46,9 @@ describe('CourseChecklistPage', () => {
   });
   describe('renders', () => {
     describe('if enable_quality prop is true', () => {
-      it('two checklist components ', () => {
+      it('two checklist components ', async () => {
         renderComponent();
-        mockStore(200);
+        await mockStore(200);
 
         expect(screen.getByText(messages.launchChecklistLabel.defaultMessage)).toBeVisible();
 
@@ -67,7 +67,7 @@ describe('CourseChecklistPage', () => {
 
         it('correct content when the launch checklist has loaded', async () => {
           renderComponent();
-          mockStore(404);
+          await mockStore(404);
           await waitFor(() => {
             const { launchChecklistStatus } = store.getState().courseChecklist.loadingStatus;
 
@@ -79,7 +79,7 @@ describe('CourseChecklistPage', () => {
 
         it('correct content when the best practices checklist is loading', async () => {
           renderComponent();
-          mockStore(404);
+          await mockStore(404);
           await waitFor(() => {
             const { bestPracticeChecklistStatus } = store.getState().courseChecklist.loadingStatus;
 
@@ -100,9 +100,9 @@ describe('CourseChecklistPage', () => {
         });
       });
 
-      it('one checklist components ', () => {
+      it('one checklist components ', async () => {
         renderComponent();
-        mockStore(200);
+        await mockStore(200);
 
         expect(screen.getByText(messages.launchChecklistLabel.defaultMessage)).toBeVisible();
 
@@ -112,7 +112,7 @@ describe('CourseChecklistPage', () => {
       describe('an aria-live region with', () => {
         it('correct content when the launch checklist has loaded', async () => {
           renderComponent();
-          mockStore(404);
+          await mockStore(404);
           await waitFor(() => {
             const { launchChecklistStatus } = store.getState().courseChecklist.loadingStatus;
 
@@ -124,7 +124,7 @@ describe('CourseChecklistPage', () => {
 
         it('correct content when the best practices checklist is loading', async () => {
           renderComponent();
-          mockStore(404);
+          await mockStore(404);
           await waitFor(() => {
             const { bestPracticeChecklistStatus } = store.getState().courseChecklist.loadingStatus;
 

src/course-libraries/LegacyLibContentBlockAlert.tsx

@@ -31,11 +31,13 @@ const LegacyLibContentBlockAlert = ({ courseId }: Props) => {
     if (taskStatus.data?.state === UserTaskStatus.Succeeded) {
       showToast(intl.formatMessage(messages.legacyLibReadyToMigrateTaskCompleted));
       setTaskId(undefined);
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       refetch();
     } else if (taskStatus.data?.state === UserTaskStatus.Failed
       || taskStatus.data?.state === UserTaskStatus.Cancelled) {
       showToast(intl.formatMessage(messages.legacyLibReadyToMigrateTaskFailed));
       setTaskId(undefined);
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       refetch();
     } else if (taskId) {
       showToast(intl.formatMessage(messages.legacyLibReadyToMigrateTaskInProgress));

src/course-outline/CourseOutline.test.tsx

@@ -471,11 +471,11 @@ describe('<CourseOutline />', () => {
     const dummyBtn = await screen.findByRole('button', { name: 'Dummy button' });
     fireEvent.click(dummyBtn);
 
-    waitFor(() => expect(axiosMock.history.post.length).toBe(3));
+    await waitFor(() => expect(axiosMock.history.post.length).toBe(3));
 
     const [section] = courseOutlineIndexMock.courseStructure.childInfo.children;
     const [subsection] = section.childInfo.children;
-    waitFor(() => {
+    await waitFor(() => {
       expect(axiosMock.history.post[2].data).toBe(JSON.stringify({
         type: COMPONENT_TYPES.libraryV2,
         category: 'vertical',
@@ -509,10 +509,10 @@ describe('<CourseOutline />', () => {
     const dummyBtn = await screen.findByRole('button', { name: 'Dummy button' });
     fireEvent.click(dummyBtn);
 
-    waitFor(() => expect(axiosMock.history.post.length).toBe(3));
+    await waitFor(() => expect(axiosMock.history.post.length).toBe(3));
 
     const [section] = courseOutlineIndexMock.courseStructure.childInfo.children;
-    waitFor(() => {
+    await waitFor(() => {
       expect(axiosMock.history.post[2].data).toBe(JSON.stringify({
         type: COMPONENT_TYPES.libraryV2,
         category: 'sequential',
@@ -545,10 +545,10 @@ describe('<CourseOutline />', () => {
     const dummyBtn = await screen.findByRole('button', { name: 'Dummy button' });
     fireEvent.click(dummyBtn);
 
-    waitFor(() => expect(axiosMock.history.post.length).toBe(3));
+    await waitFor(() => expect(axiosMock.history.post.length).toBe(3));
 
     const courseUsageKey = courseOutlineIndexMock.courseStructure.id;
-    waitFor(() => {
+    await waitFor(() => {
       expect(axiosMock.history.post[2].data).toBe(JSON.stringify({
         type: COMPONENT_TYPES.libraryV2,
         category: 'chapter',

src/course-outline/OutlineAddChildButtons.tsx

@@ -321,6 +321,7 @@ const LegacyOutlineAddChildButtons = ({
   }
 
   const handleOnComponentSelected = (selected: SelectedComponent) => {
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     onUseLibraryContent(selected);
     closeAddLibrarySectionModal();
   };

src/course-outline/card-header/CardHeader.test.tsx

@@ -229,7 +229,7 @@ describe('<CardHeader />', () => {
     });
 
     expect(await screen.findByTestId('subsection-edit-field')).toBeInTheDocument();
-    waitFor(() => {
+    await waitFor(() => {
       expect(screen.queryByTestId('subsection-card-header__expanded-btn')).not.toBeInTheDocument();
       expect(screen.queryByTestId('edit-button')).not.toBeInTheDocument();
     });

src/course-outline/hooks.jsx

@@ -113,6 +113,7 @@ const useCourseOutline = ({ courseId }) => {
 
   const headerNavigationsActions = {
     handleNewSection: () => {
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       handleAddSection.mutateAsync({
         type: ContainerType.Chapter,
         parentLocator: courseStructure?.id,

src/course-outline/section-card/SectionCard.test.tsx

@@ -318,12 +318,12 @@ describe('<SectionCard />', () => {
     renderComponent();
     const element = await screen.findByTestId('section-card');
     const menu = await within(element).findByTestId('section-card-header__menu-button');
-    await fireEvent.click(menu);
+    fireEvent.click(menu);
 
     const manageTagsBtn = await within(element).findByTestId('section-card-header__menu-manage-tags-button');
     expect(manageTagsBtn).toBeInTheDocument();
 
-    await fireEvent.click(manageTagsBtn);
+    fireEvent.click(manageTagsBtn);
 
     const drawer = await screen.findByRole('alert');
     expect(within(drawer).getByText(/manage tags/i));
@@ -364,12 +364,12 @@ describe('<SectionCard />', () => {
     renderComponent();
     const element = await screen.findByTestId('section-card');
     const menu = await within(element).findByTestId('section-card-header__menu-button');
-    await fireEvent.click(menu);
+    fireEvent.click(menu);
 
     const manageTagsBtn = await within(element).findByTestId('section-card-header__menu-manage-tags-button');
     expect(manageTagsBtn).toBeInTheDocument();
 
-    await fireEvent.click(manageTagsBtn);
+    fireEvent.click(manageTagsBtn);
 
     await waitFor(() => {
       expect(mockSetCurrentPageKey).toHaveBeenCalledWith('align', section.id);

src/course-outline/status-bar/hooks.ts

@@ -32,6 +32,7 @@ export function useDynamicHookShim() {
       }
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     load();
 
     return () => {

src/course-outline/subsection-card/SubsectionCard.test.tsx

@@ -428,12 +428,12 @@ describe('<SubsectionCard />', () => {
     renderComponent();
     const element = await screen.findByTestId('subsection-card');
     const menu = await within(element).findByTestId('subsection-card-header__menu-button');
-    await fireEvent.click(menu);
+    fireEvent.click(menu);
 
     const manageTagsBtn = await within(element).findByTestId('subsection-card-header__menu-manage-tags-button');
     expect(manageTagsBtn).toBeInTheDocument();
 
-    await fireEvent.click(manageTagsBtn);
+    fireEvent.click(manageTagsBtn);
 
     const drawer = await screen.findByRole('alert');
     expect(within(drawer).getByText(/manage tags/i));
@@ -474,12 +474,12 @@ describe('<SubsectionCard />', () => {
     renderComponent();
     const element = await screen.findByTestId('subsection-card');
     const menu = await within(element).findByTestId('subsection-card-header__menu-button');
-    await fireEvent.click(menu);
+    fireEvent.click(menu);
 
     const manageTagsBtn = await within(element).findByTestId('subsection-card-header__menu-manage-tags-button');
     expect(manageTagsBtn).toBeInTheDocument();
 
-    await fireEvent.click(manageTagsBtn);
+    fireEvent.click(manageTagsBtn);
 
     await waitFor(() => {
       expect(mockSetCurrentPageKey).toHaveBeenCalledWith('align', subsection.id);

src/course-outline/unit-card/UnitCard.test.tsx

@@ -286,12 +286,12 @@ describe('<UnitCard />', () => {
     renderComponent();
     const element = await screen.findByTestId('unit-card');
     const menu = await within(element).findByTestId('unit-card-header__menu-button');
-    await fireEvent.click(menu);
+    fireEvent.click(menu);
 
     const manageTagsBtn = await within(element).findByTestId('unit-card-header__menu-manage-tags-button');
     expect(manageTagsBtn).toBeInTheDocument();
 
-    await fireEvent.click(manageTagsBtn);
+    fireEvent.click(manageTagsBtn);
 
     const drawer = await screen.findByRole('alert');
     expect(within(drawer).getByText(/manage tags/i));
@@ -332,12 +332,12 @@ describe('<UnitCard />', () => {
     renderComponent();
     const element = await screen.findByTestId('unit-card');
     const menu = await within(element).findByTestId('unit-card-header__menu-button');
-    await fireEvent.click(menu);
+    fireEvent.click(menu);
 
     const manageTagsBtn = await within(element).findByTestId('unit-card-header__menu-manage-tags-button');
     expect(manageTagsBtn).toBeInTheDocument();
 
-    await fireEvent.click(manageTagsBtn);
+    fireEvent.click(manageTagsBtn);
 
     await waitFor(() => {
       expect(mockSetCurrentPageKey).toHaveBeenCalledWith('align', unit.id);

src/course-outline/unit-card/UnitCard.tsx

@@ -157,6 +157,7 @@ const UnitCard = ({
   };
 
   const handleCopyClick = () => {
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     copyToClipboard(id);
   };
 

src/course-rerun/CourseRerun.test.jsx

@@ -17,6 +17,13 @@ jest.mock('react-redux', () => ({
   useSelector: jest.fn(),
 }));
 
+const mockNavigate = jest.fn();
+
+jest.mock('react-router-dom', () => ({
+  ...jest.requireActual('react-router-dom'), // use actual for all non-hook parts
+  useNavigate: () => mockNavigate,
+}));
+
 describe('<CourseRerun />', () => {
   beforeEach(() => {
     const { axiosMock } = initializeMocks();
@@ -30,13 +37,13 @@ describe('<CourseRerun />', () => {
     expect(getAllByRole('button', { name: messages.cancelButton.defaultMessage }).length).toBe(2);
   });
 
-  it('should navigate to /home on cancel button click', () => {
+  it('should navigate to /home on cancel button click', async () => {
     const { getAllByRole } = render(<CourseRerun />);
     const cancelButton = getAllByRole('button', { name: messages.cancelButton.defaultMessage })[0];
 
     fireEvent.click(cancelButton);
-    waitFor(() => {
-      expect(window.location.pathname).toBe('/home');
+    await waitFor(() => {
+      expect(mockNavigate).toHaveBeenCalledWith('/home');
     });
   });
 

src/course-unit/CourseUnit.test.jsx

@@ -7,7 +7,14 @@ import {
 import { cloneDeep, set } from 'lodash';
 
 import {
-  act, fireEvent, render, waitFor, within, screen, initializeMocks,
+  act,
+  cleanup,
+  fireEvent,
+  initializeMocks,
+  render,
+  waitFor,
+  within,
+  screen,
 } from '@src/testUtils';
 import { IFRAME_FEATURE_POLICY } from '@src/constants';
 import { mockWaffleFlags } from '@src/data/apiHooks.mock';
@@ -790,9 +797,10 @@ describe('<CourseUnit />', () => {
       .reply(200, {
         ...updatedCourseSectionVerticalData,
       });
+    cleanup(); // clear the first render before we create the second.
     render(<RootWrapper />);
     // to wait for loading
-    screen.findByTestId('unit-header-title');
+    await screen.findByTestId('unit-header-title');
     // The new unit button should not be visible when childAddable is false
     expect(
       screen.queryByRole('button', { name: courseSequenceMessages.newUnitBtnText.defaultMessage }),

src/course-unit/unit-sidebar/unit-info/UnitInfoSidebar.tsx

@@ -88,6 +88,7 @@ const UnitInfoSettings = () => {
     groupAccess: Object | null,
     isDiscussionEnabled: boolean,
   ) => {
+    // oxlint-disable-next-line @typescript-eslint/await-thenable - this dispatch() IS returning a promise.
     await dispatch(editCourseUnitVisibilityAndData(
       id,
       PUBLISH_TYPES.republish,

src/course-updates/update-form/UpdateForm.jsx

@@ -83,8 +83,10 @@ const UpdateForm = ({
                     showPopperArrow={false}
                     onChange={(value) => {
                       if (!isValidDate(value)) {
+                        /* istanbul ignore next */
                         return;
                       }
+                      // eslint-disable-next-line @typescript-eslint/no-floating-promises
                       setFieldValue('date', convertToStringFromDate(value));
                     }}
                   />
@@ -103,8 +105,8 @@ const UpdateForm = ({
                 data-testid="course-updates-wisiwyg-editor"
                 name={contentFieldName}
                 minHeight={300}
-                onChange={(value) => {
-                  setFieldValue(contentFieldName, value || DEFAULT_EMPTY_WYSIWYG_VALUE);
+                onChange={/* istanbul ignore next: we can't test WYSIWYG editors */async (value) => {
+                  await setFieldValue(contentFieldName, value || DEFAULT_EMPTY_WYSIWYG_VALUE);
                 }}
               />
             </Form.Group>