feat(authz): implement filters and sorting on audit user page by jacobo-dominguez-wgu · Pull Request #110 · openedx/frontend-app-admin-console

jacobo-dominguez-wgu · 2026-03-26T17:31:02Z

Description

Adding filtering and sorting to the roles table on audit user page.
Adds the functionality to filter by Organization and Role and sorting by Role, Organization, and Scope A to Z and Z to A.

It closes #88.

~~Unit tests are pending and also some TODOs to be solved when the API is integrated.~~ ✅

Warning

Will be on draft status until the required endpoints are completed.
This PR requires the endpoints proposed in the section "Proposed Endpoint for M2"

How to test it

Pre - requisites

A running local tutor instance.
The all required endpoints are already merged on https://github.com/openedx/openedx-authz

1 - Go to the new audit user page -> http://apps.local.openedx.io:2025/admin-console/authz/user/:username (select a user with many roles assigned to get a more populated table) or go to http://apps.local.openedx.io:2025/admin-console/authz/ and click on the Eye Icon button on one of the rows of the team members table.
2 - Verify filters for orgs and roles and sorting works properly.
3 - Validate all the data loads properly, the UI matches the design and acceptance criteria is fulfilled.

NOTE: Expand all permissions and delete functionality are on different prs.
NOTE 2: The "Assign Role" button redirects to the new role assignation wizard (in development here #109 and #111).

openedx-webhooks · 2026-03-26T17:31:07Z

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-04-15T21:40:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.70%. Comparing base (0d4f93e) to head (eabb149).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   96.20%   96.70%   +0.50%     
==========================================
  Files          81       81              
  Lines        1869     1880      +11     
  Branches      413      418       +5     
==========================================
+ Hits         1798     1818      +20     
+ Misses         68       59       -9     
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jesusbalderramawgu · 2026-04-20T01:28:13Z

I have updated this PR, @jacobo-dominguez-wgu could you please remove the draft status on this PR so Diana can review it?

dcoa

This is a very light review, as you already know I'm not available at the beginning of the week.

So I cannot approve without a proper test of the feature.

dcoa · 2026-04-20T04:10:27Z

+                path={ROUTES.AUDIT_USER_PATH}
+                element={<AuditUserPage />}
+              />
+              <Route path="*" element={<NotFoundError />} />


This is a duplication, is'n it?
I see the same at line 37

This is a duplication, is'n it? I see the same at line 37

ay yeah you are right, I've updated this already. Thanks

dcoa · 2026-04-20T04:14:25Z

Same comment as previous PRs about

Same comment as previous PRs about

you mean, this one. right?

I'm not against introducing this test but I don't think it will introduce much value either.
I explain better, the functions usually call getAuthenticatedHttpClient and return a camel cased value, the logic is simple.
In addition, the hooks test follows the same pattern as here, mocking getAuthenticatedHttpClient, with the idea to cover the api during the test coverage. because of that, I prefer modify them if we find improvements than creating a solo api test suite.

rodmgwgu

Did a high level test on my local and functionality looks good, there is just one wrong filter in the Roles filters, that also appears in the Team Members page:

The "Library Collaborator" should be "Library Contributor" (also the filter sent to the query is wrong for this one)

jesusbalderramawgu · 2026-04-20T20:07:48Z

Did a high level test on my local and functionality looks good, there is just one wrong filter in the Roles filters, that also appears in the Team Members page:

The "Library Collaborator" should be "Library Contributor" (also the filter sent to the query is wrong for this one)

Thank you Rodrigo, for your feedback. this has been fixed!

rodmgwgu · 2026-04-20T20:56:31Z

Did a high level test on my local and functionality looks good, there is just one wrong filter in the Roles filters, that also appears in the Team Members page:
The "Library Collaborator" should be "Library Contributor" (also the filter sent to the query is wrong for this one)

Thank you Rodrigo, for your feedback. this has been fixed!

Thanks!, that works fine now, however I'm now seeing a different issue I didn't see before:

The scroll area doesn't reach the full height of the page, and when a filter dropdown is open, it get's partially hidden, I can scroll, but it doesn't use the whole page height.

rodmgwgu

Thanks for this work, just found some things that need changes.

rodmgwgu · 2026-04-20T21:40:41Z

+    const roleData = permissionsList.find(item => item.role === role);
+    return roleData ? roleData.permissions.length : 0;
+  */
+  const count = Math.floor(Math.random() * 50);


Actually I see that this is a placeholder, can we remove it?

rodmgwgu · 2026-04-20T21:45:00Z

        variant="reduced"
        currentPage={pageIndex + 1}
        pageCount={pageCount}
+        paginationLabel="Table pagination"


Should we use formatMessage here for i18n?

rodmgwgu · 2026-04-21T16:40:48Z

Did a high level test on my local and functionality looks good, there is just one wrong filter in the Roles filters, that also appears in the Team Members page:
The "Library Collaborator" should be "Library Contributor" (also the filter sent to the query is wrong for this one)

Thank you Rodrigo, for your feedback. this has been fixed!

Thanks!, that works fine now, however I'm now seeing a different issue I didn't see before:

The scroll area doesn't reach the full height of the page, and when a filter dropdown is open, it get's partially hidden, I can scroll, but it doesn't use the whole page height.

@jacobo-dominguez-wgu @jesusbalderramawgu This issue seems to be related to breakpoints, I only see it on smaller screens:

…vements on the header

jesusbalderramawgu · 2026-04-21T19:06:17Z

I have solved the conflicts, made the rebase and fix a minor things.

rodmgwgu

Thanks! I verified and the filter menu overflow issue is fixed

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 26, 2026

openedx-webhooks added this to Contributions Mar 26, 2026

github-project-automation Bot moved this to Needs Triage in Contributions Mar 26, 2026

mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Mar 27, 2026

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 27, 2026

jacobo-dominguez-wgu force-pushed the audit-page-filtering branch from 3be3af0 to 798b19d Compare March 31, 2026 02:04

jesusbalderramawgu force-pushed the audit-page-filtering branch 2 times, most recently from 92a07c5 to 3ba621c Compare April 15, 2026 21:08

jesusbalderramawgu force-pushed the audit-page-filtering branch from 57714f2 to 2e03479 Compare April 20, 2026 00:54

jacobo-dominguez-wgu marked this pull request as ready for review April 20, 2026 01:28

jacobo-dominguez-wgu requested a review from dcoa April 20, 2026 01:28

jacobo-dominguez-wgu assigned jesusbalderramawgu Apr 20, 2026

jacobo-dominguez-wgu moved this from Waiting on Author to Ready for Review in Contributions Apr 20, 2026

dcoa reviewed Apr 20, 2026

View reviewed changes

jesusbalderramawgu requested a review from dcoa April 20, 2026 15:10

mariajgrimaldi requested a review from bra-i-am April 20, 2026 17:17

rodmgwgu requested review from diana-villalvazo-wgu April 20, 2026 18:38

rodmgwgu reviewed Apr 20, 2026

View reviewed changes

rodmgwgu suggested changes Apr 20, 2026

View reviewed changes

jacobo-dominguez-wgu force-pushed the audit-page-filtering branch from 5b72c81 to b754ce1 Compare April 20, 2026 22:37

dcoa changed the title ~~Implementing filters and sorting on audit user page~~ feat(authz): implement filters and sorting on audit user page Apr 21, 2026

refactor: moving files from libraries to authz module and minor impro…

30c711e

…vements on the header

jacobo-dominguez-wgu and others added 21 commits April 21, 2026 12:29

feat: roles table for audit user page

c890104

feat: roles table for audit user page

42dd537

feat: adding filtering and sorting to audit user table

43cf50f

fix: orgs and roles filter fixed to send correct values to API

6099cb7

chore: spaces and imports changed

d323999

fix: tests fixed and missing props added

c548b36

feat: missing tests added to get the correct coverage

c93447c

feat: tests added in api to get correct coverage

643133a

feat: tests to get more coverage

c83b8e1

fix: tableControlBar tests fixed

99c4979

feat: missing tests for ProtectedRoute and TableControlBar

78a60d5

chore: unnecessary test removed

79b3b44

chore: unnecessary file removed

8c3b463

fix: missing code in filters

01869f0

fix: lint fixes

db7a09f

feat: tests added to utils.tsx

ccfc5dc

fix: unnecessary code removed after rebase

0df0065

fix: Role filter name fixed

8c9be4e

fix: Role filter name fixed

c2dd278

fix: addressing pr comments

2126d9a

fix: name filter fix sending the correct value

82211dc

jesusbalderramawgu force-pushed the audit-page-filtering branch from 66a8195 to 82211dc Compare April 21, 2026 18:57

fix: tests and code fixed in audit userafter rebase

bb9cd1b

fix: css workaround to open filter dropdown hidden

eabb149

jacobo-dominguez-wgu requested a review from rodmgwgu April 21, 2026 20:00

rodmgwgu approved these changes Apr 21, 2026

View reviewed changes

jacobo-dominguez-wgu merged commit e592eca into openedx:master Apr 21, 2026
6 checks passed

github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 21, 2026

jesusbalderramawgu mentioned this pull request Apr 24, 2026

fix: header table change to avoid key error due to paragon, missing flag added #143

Merged

Conversation

jacobo-dominguez-wgu commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How to test it

Pre - requisites

Uh oh!

openedx-webhooks commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jesusbalderramawgu commented Apr 20, 2026

Uh oh!

dcoa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcoa Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

dcoa Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

rodmgwgu left a comment

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu commented Apr 20, 2026

Uh oh!

rodmgwgu commented Apr 20, 2026

Uh oh!

rodmgwgu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rodmgwgu Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

jacobo-dominguez-wgu Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

rodmgwgu Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodmgwgu commented Apr 21, 2026

Uh oh!

jesusbalderramawgu commented Apr 21, 2026

Uh oh!

rodmgwgu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jacobo-dominguez-wgu commented Mar 26, 2026 •

edited

Loading

openedx-webhooks commented Mar 26, 2026 •

edited

Loading

codecov Bot commented Apr 15, 2026 •

edited

Loading

dcoa left a comment •

edited

Loading

rodmgwgu Apr 20, 2026 •

edited

Loading