Skip to content

Commit 5b72c81

Browse files
fix: addressing pr comments
1 parent 8878f3b commit 5b72c81

4 files changed

Lines changed: 5 additions & 52 deletions

File tree

src/authz-module/audit-user/utils.test.tsx

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/authz-module/audit-user/utils.tsx

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/authz-module/components/TableFooter/TableFooter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const Footer = () => {
1919
variant="reduced"
2020
currentPage={pageIndex + 1}
2121
pageCount={pageCount}
22-
paginationLabel="Table pagination"
22+
paginationLabel={formatMessage(messages['authz.table.footer.pagination.label'])}
2323
onPageSelect={(pageNum) => gotoPage(pageNum - 1)}
2424
/>
2525
</TableFooter>

src/authz-module/components/messages.ts

Lines changed: 4 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -117,40 +117,10 @@ const messages = defineMessages({
117117
defaultMessage: 'View all permissions',
118118
description: 'Text for the link to view all permissions in the user table',
119119
},
120-
'authz.table.footer.items.showing.text': {
121-
id: 'authz.table.footer.items.showing.text',
122-
defaultMessage: 'Showing {pageSize} of {itemCount} users.',
123-
description: 'Message displayed when the user reaches the applied filters limit',
124-
},
125-
'authz.table.controlbar.clearFilters': {
126-
id: 'authz.table.controlbar.clearFilters',
127-
defaultMessage: 'Clear filters',
128-
description: 'Button to clear all active filters in the table',
129-
},
130-
'authz.table.controlbar.search': {
131-
id: 'authz.table.controlbar.search',
132-
defaultMessage: 'Search',
133-
description: 'Search placeholder for two specific fields',
134-
},
135-
'authz.table.controlbar.search.by.fields': {
136-
id: 'authz.table.controlbar.search.by.fields',
137-
defaultMessage: 'Search by {firstField} or {secondField}',
138-
description: 'Search placeholder for two specific fields',
139-
},
140-
'authz.table.controlbar.filterby.label': {
141-
id: 'authz.table.controlbar.filterby.label',
142-
defaultMessage: 'Filtered by: ',
143-
description: 'Label for active filters in the table',
144-
},
145-
'authz.table.controlbar.filters.limit.reached': {
146-
id: 'authz.table.controlbar.filters.limit.reached',
147-
defaultMessage: '10 filter limit reached. Remove one of the applied filters so you can select another one.',
148-
description: 'Message displayed when the user reaches the applied filters limit',
149-
},
150-
'authz.table.controlbar.filters.items.showing': {
151-
id: 'authz.table.controlbar.filters.items.showing',
152-
defaultMessage: 'Showing {current} of {total}.',
153-
description: 'Message displayed when the user reaches the applied filters limit',
120+
'authz.table.footer.pagination.label': {
121+
id: 'authz.table.footer.pagination.label',
122+
defaultMessage: 'Table pagination',
123+
description: 'Label for the table pagination controls',
154124
},
155125
});
156126

0 commit comments

Comments
 (0)