Skip to content

fix: header table change to avoid key error due to paragon, missing flag added#143

Merged
jacobo-dominguez-wgu merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:ui-fixes
Apr 24, 2026
Merged

fix: header table change to avoid key error due to paragon, missing flag added#143
jacobo-dominguez-wgu merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:ui-fixes

Conversation

@jesusbalderramawgu
Copy link
Copy Markdown
Contributor

Description

after the testing the whole integration, it was found an error with the filters due to a key duplicated.
this is part of this merged PR

fix

refactor in the getCellHeader given that the current implementation was causing a key error due paragon issue with the JSX

Note: also a missing flag was added to render correctly the Courses Roles and permissions, this was removed after the rebase

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 24, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.46%. Comparing base (adf92ef) to head (3098e4b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   97.36%   97.46%   +0.09%     
==========================================
  Files          89       89              
  Lines        2129     2133       +4     
  Branches      496      501       +5     
==========================================
+ Hits         2073     2079       +6     
+ Misses         53       52       -1     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/authz-module/components/utils.tsx Outdated
* react-table's render('Header') calls the function as a component, so the
* JSX is still rendered correctly in the table header.
*/
export const getCellHeader = (columnId: string, columnTitle: string, filtersApplied: string[]) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be new code, but I don't see where is this being used? can you explain please?

Copy link
Copy Markdown
Contributor Author

@jesusbalderramawgu jesusbalderramawgu Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I made a mistake with the files when I made the commit I discard the correct files, I have updated the PR now with the correct ones

Copy link
Copy Markdown

@rodmgwgu rodmgwgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working great, thanks!

@jacobo-dominguez-wgu jacobo-dominguez-wgu merged commit bceb3c0 into openedx:master Apr 24, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants