feat: enable libcurl for znc-push#55
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
mbologna
force-pushed
the
feat/enable_curl_for_znc-push
branch
from
8080b98 to
ece4d55
Compare
|
I am a bot, here are the test results for this PR:
|
mbologna
force-pushed
the
feat/enable_curl_for_znc-push
branch
from
ece4d55 to
da675bf
Compare
Before enabling libcurl in znc-push, some notifications were not delivered, especially messages that were sent in burst. Working example: ``` <*push> Building notification to api.telegram.org/botXXX/sendMessage... <*push> Request sending <*push> Status: 200 <*push> Message: OK ... ``` Broken example: ``` <*push> Building notification to api.telegram.org/botXXX/sendMessage... <*push> Request sending ... <Notification not delivered> ``` Ref: https://github.com/amyreese/znc-push/blob/master/README.md#advanced ``` Note: You are strongly encouraged to use libcurl transport. The reason for that is, that the default CSocket transport doesn't verify server's SSL certificate which leaves you vulnerable to MITM attacks. However, use of libcurl will block the main ZNC thread at every push notification; for installations with many users, libcurl is not yet ideal, even with the above security concerns in mind. ``` I subsequently enabled libcurl in push.cpp compilation. I could not modify the Makefile because it is overwritten for every module downloaded, but I could override the cpp file before building the module. After using libcurl, I could receive all the notifications sent by znc-push.
mbologna
force-pushed
the
feat/enable_curl_for_znc-push
branch
from
da675bf to
6fc8a03
Compare
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
We don't know how many users our image consumers has, and the disclaimer for libcurl locking ZNC is not really worth lessening the experience for others.
|
3 participants
Description:
Before enabling libcurl in znc-push, some notifications were not delivered, especially messages that were sent in burst.
Working example:
Broken example:
Ref: https://github.com/amyreese/znc-push/blob/master/README.md#advanced
I subsequently enabled libcurl in push.cpp compilation.
I could not modify the Makefile because it is overwritten for every module downloaded, but I could override the cpp file before building the module.
After using libcurl, I could receive all the notifications sent by znc-push.
Benefits of this PR and context:
Make znc-push use libcurl for reliable notifications
How Has This Been Tested?
Rebuilt the docker-znc image and tested it is working: znc-push is using libcurl (
/msg *push set debug on)Source / References:
https://github.com/amyreese/znc-push/blob/master/README.md#advanced