Skip to content

Commit 8080b98

Browse files
committed
feat: enable libcurl for znc-push
Before enabling libcurl in znc-push, some notifications were not delivered, especially messages that were sent in burst. Working example: ``` <*push> Building notification to api.telegram.org/botXXX/sendMessage... <*push> Request sending <*push> Status: 200 <*push> Message: OK ... ``` Broken example: ``` <*push> Building notification to api.telegram.org/botXXX/sendMessage... chat_id=199357051&text=%23%23balera%3A+%5Bgodog%5D+https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DBD7n99s9bSU <*push> Request sending ... <Notification not delivered> ``` Ref: https://github.com/amyreese/znc-push/blob/master/README.md#advanced I subsequently enabled libcurl in push.cpp compilation and I no longer had this problem. I could not modify the Makefile because it is overwritten for every module downloaded, but I could override the cpp file before building the module.
1 parent 9e70e2c commit 8080b98

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ RUN \
1717
boost-dev\
1818
build-base \
1919
c-ares-dev \
20+
curl-dev \
2021
cyrus-sasl-dev \
2122
gettext-dev \
2223
git \
@@ -55,6 +56,7 @@ RUN \
5556
tar xf \
5657
/tmp/znc-push.tar.gz -C \
5758
/tmp/znc/modules --strip-components=1 && \
59+
sed -i '1i #define USE_CURL' /tmp/znc/modules/push.cpp && \
5860
curl -o \
5961
/tmp/znc-clientbuffer.tar.gz -L \
6062
https://github.com/CyberShadow/znc-clientbuffer/archive/master.tar.gz && \

Dockerfile.aarch64

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ RUN \
1616
boost-dev\
1717
build-base \
1818
c-ares-dev \
19+
curl-dev \
1920
cyrus-sasl-dev \
2021
gettext-dev \
2122
git \
@@ -51,6 +52,7 @@ RUN \
5152
curl -o \
5253
/tmp/znc-push.tar.gz -L \
5354
https://github.com/jreese/znc-push/archive/master.tar.gz && \
55+
sed -i '1i #define USE_CURL' /tmp/znc/modules/push.cpp && \
5456
tar xf \
5557
/tmp/znc-push.tar.gz -C \
5658
/tmp/znc/modules --strip-components=1 && \

0 commit comments

Comments
 (0)