Commit 6fc8a03
committed
feat: enable libcurl for znc-push
Before enabling libcurl in znc-push, some notifications were not
delivered, especially messages that were sent in burst.
Working example:
```
<*push> Building notification to
api.telegram.org/botXXX/sendMessage...
<*push> Request sending
<*push> Status: 200
<*push> Message: OK
...
```
Broken example:
```
<*push> Building notification to
api.telegram.org/botXXX/sendMessage...
<*push> Request sending
...
<Notification not delivered>
```
Ref: https://github.com/amyreese/znc-push/blob/master/README.md#advanced
```
Note: You are strongly encouraged to use libcurl transport. The reason
for that is, that the default CSocket transport doesn't verify server's
SSL certificate which leaves you vulnerable to MITM attacks. However,
use of libcurl will block the main ZNC thread at every push
notification; for installations with many users, libcurl is not yet
ideal, even with the above security concerns in mind.
```
I subsequently enabled libcurl in push.cpp compilation.
I could not modify the Makefile because it is overwritten for every
module downloaded, but I could override the cpp file before building the
module.
After using libcurl, I could receive all the notifications sent by
znc-push.1 parent 9e70e2c commit 6fc8a03
2 files changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| 59 | + | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
0 commit comments