Skip to content

integration: fix flaky testTeamAdminCanReplaceMembers await timeout #5317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackheaven wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

integration: fix flaky testTeamAdminCanReplaceMembers await timeout #5317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion integration/test/Test/Channels.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import API.Common (randomName)
import API.Galley
import API.GalleyInternal hiding (getConversation, setTeamFeatureConfig)
import qualified API.GalleyInternal as I
import Control.Monad.Reader (local)
import GHC.Stack
import MLS.Util
import Notifications (isChannelAddPermissionUpdate, isMemberJoinNotif, isWelcomeNotif)
Expand Down Expand Up @@ -526,8 +527,11 @@ testTeamAdminCanAddMembersWithoutJoining = do
selfQid <- self %. "qualified_id"
filterM (\m -> (/= selfQid) <$> (m %. "qualified_id")) allUsers

setTimeoutTo :: Int -> Env -> Env
setTimeoutTo tSecs env = env {timeOutSeconds = tSecs}

testTeamAdminCanReplaceMembers :: (HasCallStack) => App ()
testTeamAdminCanReplaceMembers = do
testTeamAdminCanReplaceMembers = local (setTimeoutTo 30) do
Comment on lines -530 to +534

@akshaymankar akshaymankar Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find out what exactly is slow and remedy that instead of increasing timeouts.

(alice, tid, bob : charlie : dylan : emil : fred : guenter : horst : ilona : _) <- createTeam OwnDomain 9
[bobId, charlieId, dylanId, emilId, fredId, guenterId, horstId, ilonaId] <-
for [bob, charlie, dylan, emil, fred, guenter, horst, ilona] (%. "id")
Expand Down