integration: fix flaky testTeamAdminCanReplaceMembers await timeout#5317
Open
blackheaven wants to merge 1 commit into
Open
integration: fix flaky testTeamAdminCanReplaceMembers await timeout#5317blackheaven wants to merge 1 commit into
blackheaven wants to merge 1 commit into
Conversation
The test awaited async conversation.member-join notifications on the default timeOutSeconds budget (10s, or only 2s when .envrc sets TEST_TIMEOUT_SECONDS=2). The notification path is multi-hop and fully async (Galley -> pushNotifications -> gundeck -> cannon -> websocket), and returns *after* the HTTP replaceMembers call already answered 200. On a loaded CI runner the delivery can exceed that budget, yielding an empty AwaitResult (zero matches, zero non-matches) timeout. Bump the per-test await budget to 30s via 'local (setTimeoutTo 30)', matching the Test.LegalHold precedent.
zebot
added
the
ok-to-test
akshaymankar
reviewed
Jul 7, 2026
Comment on lines
-530
to
+534
| testTeamAdminCanReplaceMembers = do | ||
| testTeamAdminCanReplaceMembers = local (setTimeoutTo 30) do |
Member
There was a problem hiding this comment.
Let's find out what exactly is slow and remedy that instead of increasing timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d