Make button height independent from state and content#296
Merged
Conversation
devmount
commented
Jun 26, 2026
Comment on lines
+32
to
+33
| disabled: false, | ||
| forceTooltip: false, |
Collaborator
Author
There was a problem hiding this comment.
This is for storybook providing a boolean toggle:
Contributor
There was a problem hiding this comment.
Thanks for adding these!
Merged
This was referenced Jun 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This change introduces a fixed height for buttons and eliminates the top and bottom padding, making their height independent from states and content height.
For example having different sized icons now results in buttons with the same height:
The same goes for buttons using borders (outline variant) or gradient outlines (brand buttons) in combination with disabled state.
Why?
Visual consistency.
Limitations and Notes
This change won't let buttons grow in height with their contents anymore. We never explicitly supported that, but if somebody used "oversized" buttons, this change would reduce their buttons to the standard button height again.
Applicable Issues
Closes #287