Fix IconButton height#298
Merged
Merged
Conversation
Member
|
Would it be possible to add a regression test? Like test the icon component for height and if it's not within a margin of error fail the test? |
Contributor
Author
|
@MelissaAutumn yep! Added tests and ESLint config fixes, thanks! |
devmount
approved these changes
Jun 26, 2026
devmount
left a comment
devmount
left a comment
Collaborator
There was a problem hiding this comment.
Perfect, thanks Davi! Works locally and tests are passing ✔️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
height: autonowWhy?
We've accidentally introduced a regression on the IconButton component when fixing the height of the base button (#296)
Applicable Issues
Closes #297
Screenshots
Before
Screen.Recording.2026-06-26.at.10.35.42.AM.mov
After
Screen.Recording.2026-06-26.at.10.36.19.AM.mov