Skip to content

Replace scarches with cellmapper in Annotation chapter - #457

Open
seohyonkim wants to merge 4 commits into
mainfrom
feature/annotation_cellmapper
Open

Replace scarches with cellmapper in Annotation chapter#457
seohyonkim wants to merge 4 commits into
mainfrom
feature/annotation_cellmapper

Conversation

@seohyonkim

Copy link
Copy Markdown
Collaborator

In this PR, scarches is replaced by cellmapper (which uses scarches), and the key takeaway regarding that part is slightly changed.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@netlify

netlify Bot commented Jul 31, 2026

Copy link
Copy Markdown

Deploy Preview for sc-best-practices ready!

Name Link
🔨 Latest commit 70c36b3
🔍 Latest deploy log https://app.netlify.com/projects/sc-best-practices/deploys/6a74a2828cbb37000871af13
😎 Deploy Preview https://deploy-preview-457--sc-best-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the enhancement New feature or request label Jul 31, 2026
Comment thread jupyter-book/cellular_structure/annotation.yml Outdated
@Zethson

Zethson commented Jul 31, 2026

Copy link
Copy Markdown
Member

Thank you !

  1. Please ensure that warnings like
/home/seokim/miniforge3/envs/annotation/lib/python3.12/site-packages/tqdm/auto.py:21: TqdmWarning: IProgress not found. Please update jupyter and ipywidgets. See https://ipywidgets.readthedocs.io/en/stable/user_install.html 
  from .autonotebook import tqdm as notebook_tqdm

are gone. Just install these in your env but don't add them to the yml. Rerun.
2. Please update the pinned lamindb versions as you're getting warnings.
3. We might want to add pynndescent as a dependency to speed this whole thing up

@LuisHeinzlmeier

Copy link
Copy Markdown
Collaborator

Just noticed that you use remove-output (see here), while I use hide-output (see here) for the ln.track output. I can't quite remember what we agreed on, but if we want to be consistent, we should stick to one option. What do you like better?

@Zethson

Zethson commented Aug 4, 2026

Copy link
Copy Markdown
Member

It should be hide-output, please.

@seohyonkim

Copy link
Copy Markdown
Collaborator Author

wait I have to rerun the whole thing one last time, it seems like somehow the new cell outputs are not saved. I'll rerun it and ping you guys! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants