Skip to content

Add support for disabling encryption and authentication - Kafka nodes - #13018

Open
scholzj wants to merge 6 commits into
mainfrom
scholzj/add-none-encryption-and-authentication
Open

Add support for disabling encryption and authentication - Kafka nodes#13018
scholzj wants to merge 6 commits into
mainfrom
scholzj/add-none-encryption-and-authentication

Conversation

@scholzj

@scholzj scholzj commented Aug 3, 2026

Copy link
Copy Markdown
Member

Type of change

  • Enhancement / new feature

Description

This PR provides the ability to disable encryption and authentication for the nodes of the Kafka cluster (controllers and brokers). It does so by providing the NONE encryption and authentication type and handling them in the configurations of the various components. This is part of the SEP-150 Configurable Cluster Security implementation.

It does not do it for the other components of the Kafka cluster, system tests and docs. Those will be done in separate PRs.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests
  • AI assistance was used to create this PR (see the Strimzi AI policy)

@scholzj scholzj added this to the 1.2.0 milestone Aug 3, 2026
@snyk-io

snyk-io Bot commented Aug 3, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.32164% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.55%. Comparing base (88e86e0) to head (37feef9).

Files with missing lines Patch % Lines
...c/main/java/io/strimzi/kafka/agent/KafkaAgent.java 89.28% 3 Missing ⚠️
...tor/cluster/model/KafkaClusterSecurityContext.java 94.59% 0 Missing and 2 partials ⚠️
...erator/cluster/operator/assembly/CaReconciler.java 60.00% 0 Missing and 2 partials ⚠️
...or/cluster/operator/resource/KafkaAgentClient.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13018      +/-   ##
============================================
+ Coverage     80.33%   80.55%   +0.22%     
- Complexity     6522     6569      +47     
============================================
  Files           343      344       +1     
  Lines         22695    22768      +73     
  Branches       3079     3101      +22     
============================================
+ Hits          18231    18340     +109     
+ Misses         3250     3206      -44     
- Partials       1214     1222       +8     
Files with missing lines Coverage Δ
.../cluster/model/KafkaAgentConfigurationBuilder.java 100.00% <100.00%> (ø)
...cluster/model/KafkaBrokerConfigurationBuilder.java 94.29% <100.00%> (+0.47%) ⬆️
...o/strimzi/operator/cluster/model/KafkaCluster.java 94.34% <100.00%> (+0.04%) ⬆️
...uster/operator/assembly/KafkaAssemblyOperator.java 84.47% <100.00%> (ø)
...cluster/operator/assembly/KafkaClusterCreator.java 94.73% <100.00%> (ø)
...tor/cluster/operator/assembly/KafkaReconciler.java 95.22% <100.00%> (ø)
...tor/cluster/operator/assembly/ReconcilerUtils.java 82.28% <100.00%> (ø)
...or/cluster/operator/resource/KafkaAgentClient.java 41.81% <0.00%> (+11.81%) ⬆️
...tor/cluster/model/KafkaClusterSecurityContext.java 96.49% <94.59%> (-3.51%) ⬇️
...erator/cluster/operator/assembly/CaReconciler.java 96.13% <60.00%> (-1.05%) ⬇️
... and 1 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scholzj

scholzj commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

/gha run pipeline=regression

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operators-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operands-amd64 (cncf-ubuntu-8-32-x86)
  • regression-brokers-and-security-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operators-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operands-arm64 (cncf-ubuntu-8-32-arm)

Tests will start after successful build completion.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎉 System test verification passed: link

@scholzj
scholzj marked this pull request as ready for review August 3, 2026 21:52
@scholzj
scholzj requested a review from a team August 3, 2026 21:52
@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch from c582676 to b2abb8d Compare August 3, 2026 21:52
@scholzj scholzj changed the title Add support for disabling encryption and authentication for Kafka nodes Add support for disabling encryption and authentication - Kafka nodes Aug 4, 2026

@ppatierno ppatierno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a first pass but planned to come back to it again.

Comment thread kafka-agent/src/main/java/io/strimzi/kafka/agent/KafkaAgent.java Outdated
Comment thread kafka-agent/src/main/java/io/strimzi/kafka/agent/KafkaAgent.java Outdated
Comment thread kafka-agent/src/main/java/io/strimzi/kafka/agent/KafkaAgent.java
@tinaselenge

Copy link
Copy Markdown
Contributor

KafkaAgentClient always uses https in the URI when connecting to the agent. I guess if the agent is configured to serve plain HTTP when TLS is disabled, it needs to be updated to use http instead?

@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch 3 times, most recently from 46b346b to a8654e8 Compare August 6, 2026 19:55
@scholzj

scholzj commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

@ppatierno @tinaselenge Your comments should be incorporated or replied to now. Thanks.

@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch from adf2f2b to f7e4336 Compare August 7, 2026 14:38
@scholzj scholzj modified the milestones: 1.2.0, 1.3.0 Aug 7, 2026
@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch 2 times, most recently from 0861b46 to d86798f Compare August 8, 2026 21:56

@tinaselenge tinaselenge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need an entry in the changelog?

@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch from 845bea7 to b930b46 Compare August 11, 2026 09:41
@scholzj

scholzj commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Do we not need an entry in the changelog?

@tinaselenge Changelog (and documentation) are in one of the PRs higher in the PR stack: #13041

@ppatierno ppatierno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few more nits, but we are almost there :-)

@ppatierno ppatierno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tinaselenge tinaselenge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM now.

@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch 2 times, most recently from c5dd418 to 9d7738e Compare August 13, 2026 15:36
scholzj and others added 6 commits August 16, 2026 11:23
@scholzj
scholzj force-pushed the scholzj/add-none-encryption-and-authentication branch from 9d7738e to 37feef9 Compare August 16, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants