Review comments PP

Signed-off-by: Jakub Scholz <[email protected]>

Author: scholzj

api/src/main/java/io/strimzi/api/kafka/model/kafka/clustersecurity/ClusterSecurity.java

@@ -18,7 +18,7 @@
 import java.util.Map;
 
 /**
- * Representation of the Cluster Security configuration.
+ * Representation of the desired Cluster Security configuration.
  */
 @Buildable(
         editableEnabled = false,

api/src/main/java/io/strimzi/api/kafka/model/kafka/clustersecurity/ClusterSecurityAuthentication.java

@@ -18,7 +18,7 @@
 import java.util.Map;
 
 /**
- * Representation of the Cluster Security authentication status.
+ * Representation of the desired Cluster Security authentication.
  */
 @Buildable(
         editableEnabled = false,

api/src/main/java/io/strimzi/api/kafka/model/kafka/clustersecurity/ClusterSecurityEncryption.java

@@ -18,7 +18,7 @@
 import java.util.Map;
 
 /**
- * Representation of the Cluster Security encryption status.
+ * Representation of the desired Cluster Security encryption.
  */
 @Buildable(
         editableEnabled = false,

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java

@@ -1906,7 +1906,7 @@ private String generatePerBrokerConfiguration(NodeRef node, KafkaPool pool, Map<
     /**
      * Internal method used to generate a Kafka agent configuration for given Kafka node.
      *
-     * @param node                  Node reference with Node ID and pod name
+     * @param node  Node reference with Node ID and pod name
      *
      * @return  String with the Kafka agent configuration
      */

cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaAgentClient.java

@@ -44,8 +44,8 @@ public class KafkaAgentClient {
     private final String namespace;
     private final Reconciliation reconciliation;
     private final String cluster;
-    private Identity identity;
-    private HttpClient httpClient;
+    private final Identity identity;
+    private final HttpClient httpClient;
 
     /**
      * Constructor
@@ -134,8 +134,7 @@ public BrokerState getBrokerState(String podName) {
         BrokerState brokerstate = new BrokerState(-1, null);
         String host = DnsNameGenerator.podDnsName(namespace, KafkaResources.brokersServiceName(cluster), podName);
         try {
-            String scheme = identity.trustSet() instanceof PemTrustSet ? "https" : "http";
-            URI uri = new URI(scheme, null, host, KAFKA_AGENT_HTTPS_PORT, BROKER_STATE_REST_PATH, null, null);
+            URI uri = new URI(identity.trustSet() instanceof PemTrustSet ? "https" : "http", null, host, KAFKA_AGENT_HTTPS_PORT, BROKER_STATE_REST_PATH, null, null);
             brokerstate = MAPPER.readValue(doGet(uri), BrokerState.class);
         } catch (JsonProcessingException e) {
             LOGGER.warnCr(reconciliation, "Failed to parse broker state", e);