Skip to content

fix: allow nil default IP flags in GetIP #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasaschan merged 1 commit into from
Jul 2, 2026
+20 −0
Merged

fix: allow nil default IP flags in GetIP #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ func (i *ipValue) Type() string {
}

func ipConv(sval string) (interface{}, error) {
if sval == "" || sval == "<nil>" {
return net.IP(nil), nil
}
ip := net.ParseIP(sval)
if ip != nil {
return ip, nil
Expand Down
17 changes: 17 additions & 0 deletions ip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,20 @@ func TestIP(t *testing.T) {
}
}
}

func TestIPNilDefault(t *testing.T) {
var addr net.IP
f := NewFlagSet("test", ContinueOnError)
f.IPVar(&addr, "address", nil, "IP Address")

ip, err := f.GetIP("address")
if err != nil {
t.Fatalf("expected nil default IP to round-trip without error, got %v", err)
}
if ip != nil {
t.Fatalf("expected nil default IP, got %v", ip)
}
if addr != nil {
t.Fatalf("expected bound IP variable to stay nil, got %v", addr)
}
}
Loading