fix: allow nil default IP flags in GetIP#483
Merged
Merged
Conversation
Author
|
Quick status update: the CLA check is green now, so the PR is no longer blocked on contributor-signature state. Current intent stays the same: make nil-default IP flags round-trip cleanly through |
tomasaschan
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net.IPflag as a nil result inGetIP()IPVar(..., nil, ...)usable for optional IP flags without forcing callers through parse errorsMotivation
When an
IPflag is declared with a nil default value, the internal string form becomes<nil>.GetIP()currently passes that throughipConv, which tries to parse it as a literal IP string and returns an error. This makes optional IP flags awkward to model when callers want an actual nil default.This change keeps the existing parsing behavior for user-provided values, but lets untouched nil defaults round-trip cleanly through
GetIP().Closes #351