[codex] Fix Pinocchio memo JS test fixtures#387
Merged
joncinque merged 2 commits intoJun 5, 2026
Conversation
Contributor
Author
|
Done, reverted the oxfmt-related changes and kept this PR scoped to the Pinocchio fixture/docs updates. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the JS test and local validator fixtures that still referenced the pre-migration
spl_memo.soartifact after the program crate was replaced by the Pinocchio-based implementation.This updates the test fixture and docs to use
target/deploy/pinocchio_memo_program.so, and adjusts the JS log assertion for the Pinocchio memo log shape.Why
The current JS client tests fail locally after
build-sbf-programbecause the checked-in setup tries to loadtarget/deploy/spl_memo.so, but the current program crate emitspinocchio_memo_program.so. Once pointed at the correct binary, the test still expected the legacy one-line memo log format rather than the Pinocchio two-line log output.Validation
cargo build-sbf --manifest-path program/Cargo.toml --tools-version v1.54SBF_OUT_DIR=/Users/mac/Documents/Private\ Payment/memo/target/deploy cargo test --workspacecargo clippy --workspace --all-targets -- --deny warningscargo fmt --all --checkpnpm buildinclients/jspnpm testinclients/jspnpm lintinclients/jsNODE_OPTIONS="$NODE_OPTIONS --experimental-vm-modules" pnpm exec jest test/unit --watchman=falseinclients/js-legacyNote: legacy validator e2e could not be completed in the Codex command runner because the background validator process does not survive across tool invocations here; the script now points at the current Pinocchio artifact.