[codex] Fix clients-js oxfmt config loading#388
Conversation
|
@lorisleiva can you take a look? Since you've been doing the oxfmt transitions, I want to be sure we don't need to fix every repo |
|
I believe this is a local Node version issue rather than a config bug:
CI runs Node 24 so it passes there and I can only reproduce the error outside of above ranges. I'd rather not switch to Btw this PR only fixes oxfmt. I think the better fix is to explicitly add I've actually got plans to go around all repos and align their orchestration (the last wave in the multi-phase process) so I've added that step to that last wave. I'll close this PR in favour of that change but thanks for flagging this. |
|
Thanks for the context, makes sense |
Summary
Fix
clients/jsOxfmt config loading by switching the config file to an ESM TypeScript module and making the format scripts pass it explicitly with-c.This keeps the shared
@solana-config/oxc/oxfmtsettings, including the generated/dist ignore patterns, without relying on the CommonJS.tsconfig shape that Oxfmt currently fails to link.Why
Running
pnpm formatinclients/jsfails onmainwith:This was originally noticed while fixing the Pinocchio JS test fixtures in #387, but was split out per review feedback.
Validation
pnpm formatinclients/jspnpm lintinclients/jspnpm buildinclients/jsNote:
pnpm testinclients/jsstill fails on this branch becausemainexpectstarget/deploy/spl_memo.so; that fixture is addressed separately in #387.