Fix adversarial options injection

docs/CHANGELOG.md

@@ -22,6 +22,9 @@ For dev or build tags, use the same logical version string embedded in the tag.
 
 ## [Unreleased]
 
+- The security controller now consumes registered adversarial settings through
+  `IOptions`, so its settings endpoint no longer reports that configured
+  adversarial features are unavailable.
 - The web footer and README now offer direct PayPal and Ko-fi links for
   supporting slskdN development.
 - GitLab CI configuration now keeps the Arch package-smoke sudoers command as

src/slskd/Common/Security/API/SecurityController.cs

@@ -48,7 +48,7 @@ public class SecurityController : ControllerBase
     public SecurityController(
         SecurityServices? security = null,
         ISecurityEventSink? eventSink = null,
-        AdversarialOptions? adversarialOptions = null,
+        IOptions<AdversarialOptions>? adversarialOptions = null,
         AnonymityTransportSelector? transportSelector = null,
         Mesh.IMeshCircuitBuilder? circuitBuilder = null,
         Mesh.IMeshPeerManager? peerManager = null,
@@ -57,7 +57,7 @@ public SecurityController(
     {
         _security = security;
         _eventSink = eventSink ?? security?.EventSink;
-        _adversarialOptions = adversarialOptions;
+        _adversarialOptions = adversarialOptions?.Value;
         _transportSelector = transportSelector;
         _circuitBuilder = circuitBuilder;
         _peerManager = peerManager;

tests/slskd.Tests.Unit/Common/Security/SecurityControllerTests.cs

@@ -110,7 +110,9 @@ private static SecurityController CreateController(
         return new SecurityController(
             security,
             security?.EventSink,
-            adversarialOptions,
+            adversarialOptions == null
+                ? null
+                : Microsoft.Extensions.Options.Options.Create(adversarialOptions),
             null,
             circuitBuilder,
             null,