Fix adversarial options injection - #267
Closed
snapetech wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IOptions<AdversarialOptions>intoSecurityControllerRoot cause
The experimental service graph registers
AdversarialOptionsthrough the options framework, butSecurityControllerrequested the value object directly. Dependency injection therefore supplied the constructor's optionalnulldefault, andGET /api/v0/security/adversarialreturned 404 even when adversarial settings were configured.Impact
Configured adversarial settings are now available to the security controller through the same registration used by the rest of the service graph.
Validation
dotnet test tests/slskd.Tests.Unit/slskd.Tests.Unit.csproj -c Release --filter FullyQualifiedName~SecurityControllerTests --no-restoreResult: 6 passed.