Skip to content

fix: accept thenable bootstrapFunction return values (#574) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturovt merged 2 commits into from
Jun 13, 2026
Merged

fix: accept thenable bootstrapFunction return values (#574) #575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
413b670
fix: accept thenable bootstrapFunction return values (#574)
kfrederix Jun 10, 2026
86ad859
refactor: use Angular ɵisPromise for bootstrap validation
kfrederix Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/single-spa-angular/src/single-spa-angular.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ApplicationRef, NgModuleRef, NgZone } from '@angular/core';
import { ɵisPromise, type ApplicationRef, type NgModuleRef, type NgZone } from '@angular/core';
import type { LifeCycles } from 'single-spa';
import { getContainerElementAndSetTemplate } from 'single-spa-angular/internals';

Expand Down Expand Up @@ -99,7 +99,7 @@ async function mount(

const bootstrapPromise = options.bootstrapFunction(props);

if (!(bootstrapPromise instanceof Promise)) {
if (!ɵisPromise(bootstrapPromise)) {
throw Error(
`single-spa-angular: the options.bootstrapFunction must return a promise, but instead returned a '${typeof bootstrapPromise}' that is not a Promise`,
);
Expand Down
Loading