fix: accept thenable bootstrapFunction return values (#574)#575
Merged
arturovt merged 2 commits intoJun 13, 2026
Merged
Conversation
Use duck-typed promise detection instead of instanceof Promise so bootstrapFunction works when Angular bundles return a Promise from a different realm or module copy. Co-authored-by: Cursor <[email protected]>
arturovt
requested changes
Jun 10, 2026
Co-authored-by: Cursor <[email protected]>
arturovt
approved these changes
Jun 11, 2026
Member
|
I'll merge this afternoon and publish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instanceof Promisewith duck-typed promise detection when validatingbootstrapFunctionreturn valuessmellsLikeAPromisehelper aligned with single-spa's own promise detectionFixes #574
Test plan
smellsLikeAPromise(native promises, foreign thenables, invalid values)yarn test@arturovt please let me know if you have any concerns about this?