Skip to content

[US-7.3 / OBT-212] Access Requests uses the shared FilterBar #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levigtri wants to merge 2 commits into
base: levigft/obt-210-us-71-a-reusable-well-designed-filter-bar-component
Choose a base branch
from
Open

[US-7.3 / OBT-212] Access Requests uses the shared FilterBar #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b4fb3
refactor(access): use the shared FilterBar on Access Requests
levigtri Jul 5, 2026
88422c3
chore(ci): empty commit to re-trigger CI checks
levigtri Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 30 additions & 38 deletions src/components/pages/AccessRequestsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,14 @@
import { useEffect, useState, useCallback, useMemo } from "react"
import { Check, X, Inbox, Filter, CheckCircle2, XCircle, Clock, MessageSquare, Calendar } from "lucide-react"
import { Check, X, Inbox, CheckCircle2, XCircle, Clock, MessageSquare, Calendar } from "lucide-react"
import { toast } from "sonner"
import { accessRequestsAPI } from "@/services/api"
import type { AccessRequestResponse, UserListResponse, AppResponse } from "@/types"
import { cn } from "@/utils/cn"
import { Badge } from "@/components/ui/badge"
import { Button } from "@/components/ui/button"
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "@/components/ui/select"
import { LoadingSpinner } from "@/components/common/LoadingSpinner"
import { EmptyState } from "@/components/common/EmptyState"
import { FilterBar } from "@/components/common/FilterBar"
import { ReviewDialog } from "@/components/pages/ReviewDialog"
import { UserAvatar } from "@/components/pages/UsersPage/UserAvatar"
import { formatDate, timeAgo } from "@/utils/format"
Expand Down Expand Up @@ -78,36 +72,34 @@ export function AccessRequestsSection({ users, apps }: AccessRequestsSectionProp

return (
<div className="space-y-4">
<div className="flex flex-wrap items-center gap-3 rounded-2xl border border-areia/15 bg-surface-alt/30 p-3.5">
<Filter className="h-4 w-4 text-verde/40" />
<Select value={filterApp} onValueChange={setFilterApp}>
<SelectTrigger className="w-full sm:w-48 bg-surface">
<SelectValue placeholder="All Apps" />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">All Apps</SelectItem>
{apps.map((app) => (
<SelectItem key={app.id} value={app.app_key}>
{app.name}
</SelectItem>
))}
</SelectContent>
</Select>
<Select value={filterStatus} onValueChange={setFilterStatus}>
<SelectTrigger className="w-full sm:w-40 bg-surface">
<SelectValue placeholder="All Statuses" />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">All Statuses</SelectItem>
<SelectItem value="pending">Pending</SelectItem>
<SelectItem value="approved">Approved</SelectItem>
<SelectItem value="rejected">Rejected</SelectItem>
</SelectContent>
</Select>
<span className="text-xs text-verde/60 tabular-nums ml-auto">
{loading ? "..." : `${requests.length} request${requests.length !== 1 ? "s" : ""}`}
</span>
</div>
<FilterBar
filters={[
{
key: "app",
label: "All Apps",
value: filterApp,
onChange: setFilterApp,
options: [
{ value: "all", label: "All Apps" },
...apps.map((app) => ({ value: app.app_key, label: app.name })),
],
},
{
key: "status",
label: "All Statuses",
value: filterStatus,
onChange: setFilterStatus,
className: "w-full sm:w-40",
options: [
{ value: "all", label: "All Statuses" },
{ value: "pending", label: "Pending" },
{ value: "approved", label: "Approved" },
{ value: "rejected", label: "Rejected" },
],
},
]}
resultLabel={loading ? "..." : `${requests.length} request${requests.length !== 1 ? "s" : ""}`}
/>

{loading ? (
<LoadingSpinner />
Expand Down
Loading