Skip to content

[US-7.3 / OBT-212] Access Requests uses the shared FilterBar - #22

Open
levigtri wants to merge 2 commits into
levigft/obt-210-us-71-a-reusable-well-designed-filter-bar-componentfrom
levigft/obt-212-us-73-the-filter-bar-to-look-polished-and-consistent
Open

[US-7.3 / OBT-212] Access Requests uses the shared FilterBar#22
levigtri wants to merge 2 commits into
levigft/obt-210-us-71-a-reusable-well-designed-filter-bar-componentfrom
levigft/obt-212-us-73-the-filter-bar-to-look-polished-and-consistent

Conversation

@levigtri

@levigtri levigtri commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

US-7.3 / OBT-212 — The Access Requests section now uses the shared FilterBar component, so filtering requests by app and status looks polished and consistent.

Changes

  1. AccessRequestsSection.tsx: replace the inline app + status filter JSX with FilterBar, passing filterApp and filterStatus as filter configs and the request count as resultLabel. Removed the now-unused Select and Filter-icon imports.

App-filter and status-filter behavior is unchanged.

Type of Change

  • Refactor

Testing

  • npm run typecheck — pass
  • npm run lint — 0 errors (pre-existing ProjectsPage warning only)
  • npm run build — pass

Stacked on US-7.1 / OBT-210 (#20) (sibling of US-7.2 #21; different file, no conflict). Merge #20 first.

levigtri and others added 2 commits July 5, 2026 01:15
Replace the inline app + status filter JSX with the shared FilterBar component,
passing filterApp and filterStatus as filter configs and the request count as
the result label. Behavior is unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: f08c9ea6-e120-4e8c-93e6-b6b15f96e6e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch levigft/obt-212-us-73-the-filter-bar-to-look-polished-and-consistent

Comment @coderabbitai help to get the list of available commands.

@levigtri levigtri self-assigned this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant