Skip to content

fix(s07): resolve Windows subprocess UnicodeDecodeError with UTF-8/GBK fallback #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiarimr wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

fix(s07): resolve Windows subprocess UnicodeDecodeError with UTF-8/GBK fallback #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions s07_skill_loading/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,23 @@ def safe_path(p: str) -> Path:
raise ValueError(f"Path escapes workspace: {p}")
return path

# s07: Fix Windows subprocess encoding crash (fallback UTF-8 -> GBK with error replacement)
def safe_decode(data: bytes) -> str:
if not data:
return ""
try:
return data.decode('utf-8')
except UnicodeDecodeError:
return data.decode('gbk')


def run_bash(command: str) -> str:
try:
r = subprocess.run(command, shell=True, cwd=WORKDIR,
capture_output=True, text=True, timeout=120)
out = (r.stdout + r.stderr).strip()
capture_output=True, timeout=120)
stdout = safe_decode(r.stdout)
stderr = safe_decode(r.stderr)
out = (stdout + stderr).strip()
return out[:50000] if out else "(no output)"
except subprocess.TimeoutExpired:
return "Error: Timeout (120s)"
Expand Down