fix(s07): resolve Windows subprocess UnicodeDecodeError with UTF-8/GBK fallback - #510
Open
xiarimr wants to merge 1 commit into
Open
fix(s07): resolve Windows subprocess UnicodeDecodeError with UTF-8/GBK fallback#510xiarimr wants to merge 1 commit into
xiarimr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
On Windows, when executing commands via
run_bash(such as inspecting or loadingskill.md), aUnicodeDecodeErroroccurs insubprocess's background reader thread (_readerthread).Trigger Scenario:
skill.mdcontains UTF-8 encoded text/characters. Whenrun_bashexecutes CLI commands that output its content, Windows defaults toGBK(CP936) for stream decoding whentext=Trueis enabled.Chain of Failure:
skill.mdfail to decode under Windows defaultGBKcodec in_readerthread.r.stdoutevaluates toNone, which triggers a secondaryTypeError: unsupported operand type(s) for +: 'NoneType' and 'str'inrun_bash.Solution
text=Truefromsubprocess.runto keep output as rawbytes.safe_decodehelper function that attemptsUTF-8decoding first, with a clean fallback toGBK.Tested Environments
s07_skill_loading